You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Try Blacksmith for the performance workflow's Android and iOS builds and measurements, to measure whether its runners improve CI duration and reduce same-code timing variation.
Keep API 36 / KVM, Xcode 26.5, the benchmark suite, calibration, sampling and per-case BASE → HEAD order unchanged. Both revisions still run on the same measurement host.
Include the requested Blacksmith tier in raw result device descriptions. Preparation, collection and trusted reporting keep their existing GitHub runners.
These are observed job durations, not a controlled hardware speedup estimate; cache and image state can differ. Both revisions were built and measured on Blacksmith, with required Android KVM and Xcode 26.5. Benchmark suite hash remains f34d9c1f3a289bdc8f9257a57ba955d72f2ca30cb632c9fcd9a554d964674b55.
The PR changes no Nitro implementation or benchmark code. It compares separately built base/head apps with different application IDs, not byte-identical apps. All 46 cases per platform completed with matching base/head operation and chunk counts.
Same-code base/head differences
Android
iOS
Median absolute change across cases
1.18%
1.09%
Cases with an absolute change of at least 5%
6/46
7/46
Largest absolute change
60.03%
14.33%
The iOS observations are encouraging compared with the earlier GitHub same-binary diagnostic (median absolute change 10.22%, 33/46 cases at least 5%), but this one run does not establish reliable detection of small regressions. Android still has a large outlier: C++ simpleFunc() reports +60.03%, with its head samples slowing approximately 92% between the first and last five. iOS's largest corresponding within-process drift was about 6.7%. No samples were discarded or thresholds adjusted.
Raw JSON and calibration/measurement records are attached to the successful CI run and linked from the bot comment. Existing compiler/React Native warnings remain, including the explicit-module compiler-selection warning addressed separately by #1610.
Attempt 1 was cancelled before platform jobs started, then retried after the Blacksmith installation was granted access to Nitro. The successful result is attempt 2 at 16367b7b5e3019a7489484c58c010c2893482c63.
Report only: Measurements do not fail this PR. Each benchmark has one base/head process pair. Samples describe within-process variation; they do not establish repeatability between launches or statistical confidence.
p50 is the median of timed batch averages in ns/op, not individual-call latency. MAD describes sample spread; ordered raw samples retain within-process drift.
p50 is the median of timed batch averages in ns/op, not individual-call latency. MAD describes sample spread; ordered raw samples retain within-process drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try Blacksmith for the performance workflow's Android and iOS builds and measurements, to measure whether its runners improve CI duration and reduce same-code timing variation.
blacksmith-4vcpu-ubuntu-2404; iOS usesblacksmith-6vcpu-macos-26(Apple Silicon).Blacksmith documents macOS 26 and x64 Linux nested virtualization support.
Validation: all 77 performance-tool tests pass; actionlint and shellcheck pass with Blacksmith's custom runner labels allowed. The trial run, attempt 2 passed all build, measurement and collection jobs. Trusted reporting succeeded, and Nitro Modules Bot posted the comparison.
These are observed job durations, not a controlled hardware speedup estimate; cache and image state can differ. Both revisions were built and measured on Blacksmith, with required Android KVM and Xcode 26.5. Benchmark suite hash remains
f34d9c1f3a289bdc8f9257a57ba955d72f2ca30cb632c9fcd9a554d964674b55.The PR changes no Nitro implementation or benchmark code. It compares separately built base/head apps with different application IDs, not byte-identical apps. All 46 cases per platform completed with matching base/head operation and chunk counts.
The iOS observations are encouraging compared with the earlier GitHub same-binary diagnostic (median absolute change 10.22%, 33/46 cases at least 5%), but this one run does not establish reliable detection of small regressions. Android still has a large outlier: C++
simpleFunc()reports +60.03%, with its head samples slowing approximately 92% between the first and last five. iOS's largest corresponding within-process drift was about 6.7%. No samples were discarded or thresholds adjusted.Raw JSON and calibration/measurement records are attached to the successful CI run and linked from the bot comment. Existing compiler/React Native warnings remain, including the explicit-module compiler-selection warning addressed separately by #1610.
Attempt 1 was cancelled before platform jobs started, then retried after the Blacksmith installation was granted access to Nitro. The successful result is attempt 2 at
16367b7b5e3019a7489484c58c010c2893482c63.