Repository navigation
Analysis: remember collapse per Roll/Frame tab, keep its height across restarts - #1374
Merged
Merged
Conversation
Analysis is pinned above both Roll and Frame, but shared one expanded state, so collapsing it on Roll also collapsed it on Frame. Each tab now keeps its own: Frame stays on section_expanded_analysis, Roll uses section_expanded_analysis_roll, and switching tabs restores it. make_section gains persist=False so a caller can own the expanded state without losing the help dialog's saved geometry.
The splitter split was set before the window was shown, when the splitter has no real height, so Qt rescaled it: a saved [500, 409] came back as [275, 634]. Starting collapsed and then expanding at startup locked in the rescaled height. The split is now applied once, after the first show, and before that no resize happens. The expanded height comes from the saved setting and from drags while Analysis is expanded. A drag of the collapsed header no longer overwrites it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
section_expanded_analysissetting. Roll uses a newsection_expanded_analysis_rollsetting. Switching tabs restores the state of the new tab.make_sectionhas a new keyword-onlypersist=Falseoption. With it, a caller can own the expanded state and keep the help dialog's saved size.[500, 409]came back as[275, 634]). The split is now applied once, after the first show. The expanded height comes from the saved setting and from drags while Analysis is expanded.Refs #1370
Test plan
make alltests/test_right_panel_wiring.py: each tab restores its own state; a drag while collapsed does not change the saved height; no resize before the first show