Repository navigation
Pin Analysis above Roll and refresh it live while dragging - #1371
Merged
Merged
Conversation
Analysis moves out of the Frame page into a splitter above the outer tab stack, shown on Roll and Frame and hidden elsewhere. Black/White Point and the other Roll cards can now be judged against the histogram without switching tabs. Refs #1370
A drag render of the edit now reads metrics back from the interactive proxy, and the Analysis panel no longer skips interactive frames, so the histogram, waveform and stats track the slider instead of waiting for release. Config-override renders (flat peek, zone preview) and the splash still skip readback so they never replace the edit's histograms. Headless drag on DSC00448.ARW: 20/20 frames refresh the chart; worker frame time 1.7 -> 20 ms median (the metrics map waits on the GPU, about 11 ms of it), _update_analysis 2.3 ms per frame on the UI thread. Fixes #1370
thetalkingdrum
added a commit
to thetalkingdrum/NegPy
that referenced
this pull request
Oct 12, 2026
Analysis now refreshes on drag frames (marcinz606#1371). The crossover readout reads the print back and measures it on the UI thread, about 16-19 ms a frame, so a drag frame keeps the last plot and the release frame redraws it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1370
Summary
_update_analysisno longer skips interactive frames. The histogram, waveform, vectorscope, stats and the small slider histograms track the slider instead of waiting for release. Config-override renders (Flat peek, zone-placement preview) and the splash still skip readback, so they never replace the edit's histograms.Cost
Headless drag (20 steps,
DSC00448.ARW, offscreen, this machine's GPU):_update_analysison UI threadMost of the added time is the metrics
map_syncwaiting for the GPU to finish the frame (about 11 ms). The old 1.7 ms only covered submission. Expect a longer wait on integrated GPUs. If that becomes a problem, throttle the drag readback to every Nth frame.Test plan
make alltest_controller.py)test_right_panel_wiring.py)🤖 Generated with Claude Code