Repository navigation
Toolbar: Tools menu, tool switcher, menu icons - #1368
Merged
Merged
Conversation
Every canvas tool has its own toolbar row, but it armed only from its sidebar card or a key. Now: - a Tools menu on the row lists them under their panel section (Geometry, Metering, Filtration, Dodge & Burn, Retouch), each with its sidebar icon and key; an item runs the tool's shortcut action, so its tab opens and a gated tool grays out - the armed tool's name on its row opens the same menu, so Heal goes to Clone with no Done between them - the ⋯ menu carries a Tools submenu - a stored row gets Tools once, before Undo; a removed one stays removed - Tools and Overlays are icon-only - the Print and Overlays menus show their icons; an item that is on takes the accent, since the icon sits in the checkmark's place - "Open Tools menu" shortcut action, unbound by default
The Print menu grayed out Flat Scan until Flat output was on in the Export tab, yet the peek renders the flat master from any frame and its key (M) always worked. The menu and the ⋯ item now match the key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolbar_added_items).Test plan
make allMainWindow: all 13 menu items arm their tools; Heal → Clone from the switcher arms Clone and turns the Heal sidebar button off; Flat Scan from the Print menu turns the peek on with Flat output off; the ⋯ Tools submenu is filledmake run: arm each tool from the menu, check the tab reveal and Done/EscOpen
grip-lines(these are the sidebar icons; the menu reuses them).