Skip to content

Prose cleanup since 0.63.0: comments and docs - #1358

Merged
marcinz606 merged 3 commits into
mainfrom
mz/prose2
Oct 11, 2026
Merged

marcinz606 merged 3 commits into
mainfrom
mz/prose2

Conversation

@marcinz606

Copy link
Copy Markdown
Owner

Cleanup pass over prose added since the 0.63.0 tag, plus a whole-file pass over the docs.

Code comments (99 files, −445 lines)

  • Removed comments that restate code, narrate history ("now", "no longer"), or quote one-run measurements and issue numbers.
  • Cut over-budget docstrings (some were 12–38 lines) to the constraint they carry. Parity/mirror notes, cache contracts and physics rules stay, one line each.
  • Proof of no code change: ast.dump of HEAD vs branch is identical with docstrings stripped, for every file except two intentional UI strings:
    • Edit Toolbar hint (canvas/toolbar.py)
    • Diffusion tooltip (sidebar/tone.py), dropped one clause
  • WGSL: code with // comments stripped is identical. noqa/type: ignore/fmt: pragmas unchanged.

Docs

File Words
USER_GUIDE.md 17,515 → 14,441
PIPELINE.md 16,874 → 14,367
CAMERA_SCANNING.md 4,344 → 3,474
CROSSTALK.md 1,875 → 1,454
README.md 1,226 → 996
CONTRIBUTING.md 1,073 → 855
TEMPLATING / FILTERING / crosstalk README −10 to −16%
CLAUDE.md, PLUSTEK_WINDOWS.md wording only
  • All 44 panel: markers stay above unchanged headings. Headings, links, formulas, constants and patent/literature citations are kept.
  • Em dashes removed from prose. Visual trivia, repeated explanations, and implementation detail that is also in PIPELINE.md are cut from the guide.
  • Fixes found on the way: crosstalk/README showed C41/E-6 as the current process values (they are Color Negative/Transparency), and the guide listed a Pakon F235 that the loader does not know. FILTERING "Behaviour" → "Behavior". Emoji removed from CONTRIBUTING headings (no links point to them).
  • Left alone: CHANGELOG, KEYBOARD (generated), NOTICE, .claude/skills.

To check

  • test_autocrop_state_table.py no longer points to the out-of-repo "Auto Crop plan", which explained the E19/P3 test ids.
  • Guide: per-tool right-click delete notes merged into one line (heals, scratches, lines and clones all have a delete action).

make all: 8682 passed, lint and type clean.

Remove comments that restate code, narrate history or quote one-run
measurements; cut over-budget docstrings to the constraint they carry.
AST-identical with docstrings stripped, except two tooltip strings
(Edit Toolbar hint, Diffusion). WGSL code unchanged.
USER_GUIDE -18%, PIPELINE -15%, CAMERA_SCANNING/CROSSTALK/README/
CONTRIBUTING ~-20%, the rest lighter. Panel markers, headings, links,
formulas, constants and citations kept. crosstalk/README now shows the
current process values (Color Negative / Transparency); the guide's
Pakon model list matches the loader.
@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Preview load metrics (github-linux-x64)

format cold load throughput
CR2 0.835 s 26.87 MPx/s
NEF 0.727 s 33.84 MPx/s
ARW 0.250 s 80.77 MPx/s
RAF 2.238 s 7.27 MPx/s
DNG 0.734 s 32.63 MPx/s

fixtures: rawsamples.ch · sha: 1614d56 · full JSON

# Conflicts:
#	docs/PIPELINE.md
#	docs/USER_GUIDE.md
#	negpy/desktop/controller.py
#	negpy/features/flatfield/logic.py
#	negpy/services/rendering/image_processor.py
@marcinz606
marcinz606 marked this pull request as ready for review October 11, 2026 15:31
@marcinz606
marcinz606 merged commit 7f9553a into main Oct 11, 2026
2 checks passed
@marcinz606
marcinz606 deleted the mz/prose2 branch October 11, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant