fix: race condition in image uploader - #779

Merged

ptpt merged 16 commits into

mainfrom

fix-race-condition-image-uploader

Aug 27, 2025

Commits on Aug 27, 2025

fix: race condition in image uploader and add tests
ptpt
committed
e551158
Add tests for ImageSequenceUploader. Follow the following principles:
ptpt
committed
395f681
I saw that you use multithreads in test_image_sequence_uploader_multithreading_with_cache_enabled. No need to do that because `sequence_uploader.upload_images` is using inside multithreading. We ca…
ptpt
committed
1560ee5
Using cached_time to determine if it's cached is probably not reliable. Try mock some internal implementation, e.g. if single_image_uploader.cache.get() is called and filehandle if filehandle is ca…
ptpt
committed
4e35c85
increase num_images
ptpt
committed
4d4b472
Ok, it looks like it is hard to tests with the current implementation. Let's make some changes in uploader.py
ptpt
committed
6fe6487
Ok now let's improve tests. As we exposed both ImageSequenceUploader.cache and SingleImageUploader.cache, which means you can update them after construction, and run assertions based on the cache i…
ptpt
committed
3e9f38d
I don't see you are calling `sequence_uploader.upload_images` in test_image_sequence_uploader_cache_hits_second_run
ptpt
committed
ec12e51
simplify tests
ptpt
committed
21495a5
enable upload_cache_path
ptpt
committed
480801f
refactor
ptpt
committed
c5c7355
update tests
ptpt
committed
93098f4
rename
ptpt
committed
932bac8
tests
ptpt
committed
31bb1a6
Assert that results from the uploader.upload_images() in TestImageSequenceUploader has not errors
ptpt
committed
5458960
cache path
ptpt
committed
45a09ed