Stats category picker: context-aware labels and unified selection colour#68
Merged
Conversation
X/Y axis labels in the summary bar and chip prefixes are now gated on chartType == SCATTER — the only chart where selections actually map to named axes. For all other chart types the summary shows bare category names and chips carry no prefix, eliminating the confusion of reading "X: Tampons Used" when looking at an Over Time bar chart. Both selected categories now use the same primaryContainer fill instead of primaryContainer for the first and secondaryContainer for the second. The hue clash (pink vs teal in the Coral theme) is gone; selection state reads as a single language across both picks. Summary bar text colours match: both names use primary rather than primary + secondary. Bumps to 0.14.1-beta.1 (versionCode 46). https://claude.ai/code/session_01CJ4t4GhU8z6TTm3kdGgEhx
Main reached 0.16.0-beta.1 while this branch was open. Changelog entry renumbered upward per policy; StatsScreen.kt auto-merged (no conflicts in the edited section). https://claude.ai/code/session_01CJ4t4GhU8z6TTm3kdGgEhx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two targeted fixes to the category picker on the Stats screen, applying the "one selection language per screen" and "colour is the cheapest separator" lessons.
X/Y labels are now context-aware
Previously the summary bar always showed
X: Tampons Used · Y: Sleepand each selected chip was prefixedXorYregardless of which chart type was active. This language only makes sense for Scatter plots (where the selections literally become X and Y axes). For every other chart type — Over Time, Average, Compare, Distribution — there are no axes, so the labels were just noise and mildly confusing.Now: X/Y labels appear only when
chartType == SCATTER. For all other chart types the summary bar showsTampons Used · Sleepand chip labels carry no prefix.Selection colour unified
Previously the first selected category used
primaryContainer(pinkish in the Coral theme) and the second usedsecondaryContainer(teal), creating an arbitrary hue clash that had nothing to do with the categories themselves or the chart being drawn.Now: both selections use
primaryContainer. The summary bar usesprimaryfor both names rather thanprimary+secondary. Selection state now reads as a single visual language — which pick is "first" is clear from order, not from a jarring colour difference.What was not changed
surfaceVariantpill) is kept — it correctly signals "this is your current configuration"Test plan
X: … · Y: …, chips showX/Yprefixeshttps://claude.ai/code/session_01CJ4t4GhU8z6TTm3kdGgEhx
Generated by Claude Code