Fix CLI integration test capture race for config-file port assertion - #14
Merged
Merged
Conversation
TestCLIConfigFilePresent, TestCLIConfigMultipleSchemas and TestCLIAsyncAPIAccepted read the mock subprocess stderr with an inline reader that stops as soon as the accumulated buffer contains "Mock server started". Because slog emits the port attribute on the same line, after that needle (msg="Mock server started" port=N), the reader can return at a 1024-byte chunk boundary that splits the line, so the trailing port=NNNNN is never read and assert.Contains(output, "port=NNNNN") fails. This is the same CI startup race the captureUntil helper was introduced for in 6188e42, but these three tests were left on the old racy pattern. Replace the inline reader + select with captureUntil for deterministic output capture. Change is test-only; verified with -count runs, full suite, lint, vet and GitNexus change analysis (LOW risk, no affected processes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestCLIConfigFilePresent, TestCLIConfigMultipleSchemas and TestCLIAsyncAPIAccepted read the mock subprocess stderr with an inline reader that stops as soon as the accumulated buffer contains "Mock server started". Because slog emits the port attribute on the same line, after that needle (msg="Mock server started" port=N), the reader can return at a 1024-byte chunk boundary that splits the line, so the trailing port=NNNNN is never read and assert.Contains(output, "port=NNNNN") fails. This is the same CI startup race the captureUntil helper was introduced for in 6188e42, but these three tests were left on the old racy pattern.
Replace the inline reader + select with captureUntil for deterministic output capture. Change is test-only; verified with -count runs, full suite, lint, vet and GitNexus change analysis (LOW risk, no affected processes).