Feature/unify example match conditions - #13
Merged
Merged
Conversation
Extract the pure event subscription broker and interval scheduler into a new internal/eventbus package so the coordinators have a real package boundary and a public test seam, and de-complexify response selection, request filtering and header resolution. Fix the JSON-RPC over HTTP transport to always answer 200 (a mocked non-2xx status is carried in X-Mock-Status), mount each RPC procedure's own path so path parameters resolve through chi, lower the complexity lint gates, and align the OpenAPI/AsyncAPI schemas, docs and OpenSpec scenarios with the implementation.
Remove the async-only match wire field from POST /_mock/examples and make conditions the single selector for every target kind. Async targets now map conditions onto the existing x-mock-match extension (event/connection/reply contexts), strict validation rejects a stale match field (RS.MAPI.37), and the generated AddExampleRequest schema is regenerated from api/openapi.yaml as the single source of truth via the new gen-control-schema tool. Update specs, docs, and tests; archive the unify-example-match-conditions change.
TestIntegration_ConnectionTargeting and TestIntegration_ReceiveBuiltIn_Runtime still sent the removed match wire field, which the unified conditions selector now rejects with HTTP 400. Switch both to conditions (RS.MAPI.33, RS.MAPI.26).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.