Harden codebase internals with behavior-neutral refactors - #11
Merged
Merged
Conversation
Bound the compiled-schema cache so a long-running mock fed distinct dynamic examples cannot leak memory; index schema prefixes by channel once so push and built-in trigger firings resolve in O(1); add Has()/connection() to the ws registry so Server stops poking lock internals; assign monotonic request ids instead of UnixNano strings; fold selectAndGenerateResponse's five returns into a responseResult with an already-parsed status code; guard recursive templating depth; dedupe config normalization; and narrow the async event/interval surface behind an asyncDriver seam with full constructor composition so eventBus is never left partially wired. External behavior, specs, docs and existing tests are unchanged; new unit tests cover the cache bound, channel-prefix index, injection seam, request-id uniqueness and the depth guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bound the compiled-schema cache so a long-running mock fed distinct dynamic examples cannot leak memory; index schema prefixes by channel once so push and built-in trigger firings resolve in O(1); add Has()/connection() to the ws registry so Server stops poking lock internals; assign monotonic request ids instead of UnixNano strings; fold selectAndGenerateResponse's five returns into a responseResult with an already-parsed status code; guard recursive templating depth; dedupe config normalization; and narrow the async event/interval surface behind an asyncDriver seam with full constructor composition so eventBus is never left partially wired.
External behavior, specs, docs and existing tests are unchanged; new unit tests cover the cache bound, channel-prefix index, injection seam, request-id uniqueness and the depth guard.