Skip to content

session: re-derive the TLS census pin at main's tip (544 -> 545) - #102

Open
brandonros wants to merge 1 commit into
malisper:mainfrom
brandonros:fix/session-tls-census-pin
Open

session: re-derive the TLS census pin at main's tip (544 -> 545)#102
brandonros wants to merge 1 commit into
malisper:mainfrom
brandonros:fix/session-tls-census-pin

Conversation

@brandonros

@brandonros brandonros commented Sep 6, 2026

Copy link
Copy Markdown

`tls_source_census_and_session_surface_are_pinned` fails on main: the tree has 545 `thread_local!` declarations and the pin says 544. The comment above the pin already warns that the number was carried from a donor branch and must be re-derived at the tip it is enforced against; this does that. No declaration has changed since bcda79e.

Independent of the objkv series, but objkv/3 (table AM) re-pins the same line at 552, so whichever lands second needs a one-line rebase.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Updated the TLS census test expectation to reflect the current count.
    • Revised the associated test comment to document the updated baseline.

tls_source_census_and_session_surface_are_pinned fails on main: the
tree has 545 thread_local! declarations and the pin says 544. The
comment above the pin already warns that the number was carried from
a donor branch and must be re-derived at the tip it is enforced
against; this does that. No declaration has changed since bcda79e.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 49b3ddde-26da-438f-acd6-48ece8afb299

📥 Commits

Reviewing files that changed from the base of the PR and between 4c2e49f and afaaee2.

📒 Files selected for processing (1)
  • crates/backend/access/session/src/tests.rs

Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The session test updates its TLS census assertion from 544 to 545. The comment records that the count was re-derived at the current main tip and that no TLS declaration changed.

Changes

TLS census validation

Layer / File(s) Summary
Update TLS census pin
crates/backend/access/session/src/tests.rs
The assertion expects 545 TLS entries. The comment explains the re-derived count and unchanged declarations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to afaae

This updates the TLS census test baseline to the current total of 545 without changing runtime behavior. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: re-deriving the TLS census pin from 544 to 545 at main's tip.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant