float: pin erf/erfc(1.0) per platform libm - #101
Conversation
Apple's libm differs from glibc by one ulp at erf(1.0) and erfc(1.0), so math_domains_and_live_pg_values failed on every macOS checkout. Pin both arms by target_os so a libm regression on either platform is still caught. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe float math test now uses target-specific expected values for ChangesFloat assertion portability
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This updates float-test expectations for the documented one-ULP macOS libm difference while retaining the existing values elsewhere. No production behavior changes, and the change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
`math_domains_and_live_pg_values` fails on every macOS checkout: Apple's libm differs from glibc by one ulp at `erf(1.0)` and `erfc(1.0)`. Pin both arms by `target_os` so a libm regression on either platform is still caught, the way the existing `lgamma` arms already do.
Verified: `cargo test -p adt_float math_domains` passes on Darwin 25.6.
🤖 Generated with Claude Code
Summary by CodeRabbit
erf(1.0)anderfc(1.0)results on macOS versus other operating systems.