Feature/form performance chart by alaca · Pull Request #207 · mailchimp/wordpress

alaca · 2026-04-21T14:25:52Z

Description of the Change

Adds the Forms performance over time chart to the Analytics admin page.

How to test the Change

Submit a few forms on the frontend to generate tracking data
Navigate to Mailchimp -> Analytics

Changelog Entry

Added - New "Forms performance over time" chart on the Analytics admin page, showing submissions over time for the selected list and date range.

Credits

Props @alaca

Checklist:

I agree to follow this project's Code of Conduct.
I have updated the documentation accordingly.
I have added tests to cover my change.
All new and existing tests pass.

alaca · 2026-04-21T14:27:09Z

@iamdharmesh I based this branch on your branch feature/200

Copilot

Pull request overview

Adds a new “Forms performance over time” chart to the Mailchimp → Analytics admin page, backed by a new admin-only AJAX endpoint that aggregates local analytics DB rows into chart-ready series.

Changes:

Registers a new wp_ajax_mailchimp_sf_get_form_performance endpoint and data provider for per-form submissions-over-time aggregation.
Adds a new Analytics card (markup + JS module) rendering a Chart.js line chart with loading/empty/error states.
Adds SCSS styling for the new Form Performance analytics section.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`mailchimp.php`	Bootstraps the new Form Performance data provider on plugin init.
`includes/class-mailchimp-form-performance.php`	Implements the AJAX handler, DB query, and bucketing/aggregation logic for the chart payload.
`includes/admin/templates/analytics.php`	Adds the new “Forms performance over time” card markup, error banner, and canvas placeholder.
`assets/js/analytics.js`	Introduces a new frontend module that fetches/render form performance data and manages UI states.
`assets/css/analytics.scss`	Styles the new Form Performance section to match existing analytics card patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…into feature/form-performance-chart

iamdharmesh

Thanks for PR @alaca. As the work still pending in this PR, I haven't reviewed this yet but just added some notes to existing feedback worth resolving. Could you please help with address those?

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T12:43:18Z

+		describe('Form performance chart (stubbed)', () => {
+			const analyticsUrl = '/wp-admin/admin.php?page=mailchimp_sf_analytics';
+
+			function stubFormPerformance(replyFn) {
+				cy.intercept('POST', '**/admin-ajax.php', (req) => {
+					if (!isFormPerformanceRequest(req)) {
+						req.continue();
+						return;
+					}
+					const payload = typeof replyFn === 'function' ? replyFn(req) : replyFn;
+					req.reply({
+						statusCode: 200,
+						headers: { 'content-type': 'application/json; charset=UTF-8' },
+						body: payload,
+					});
+				}).as('formPerformance');
+			}


The Form performance Cypress tests only stub the mailchimp_sf_get_form_performance admin-ajax call, but assets/js/analytics.js dispatches mailchimp-analytics-refresh on page init, which also triggers a mailchimp_sf_get_subscriber_activity request. Without stubbing that request here, these tests can hit the real subscriber-activity endpoint (and potentially the external Mailchimp API), making CI runs flaky. Consider stubbing subscriber activity in this describe as well (e.g., return a basic wpJsonSuccess(buildSuccessData())) so the page’s other analytics section doesn’t make real network calls during these tests.

iamdharmesh

Thanks for the changes @alaca. This looks good now. I just added minor comment regarding empty state. Once that is resolved. we are good to go here.

iamdharmesh · 2026-04-30T12:51:45Z

+			const totalSubs = payload.total_submissions || 0;
+
+			// Empty when there's literally no tracked activity for the range.
+			if (rows.length === 0 || (totalViews === 0 && totalSubs === 0)) {


Just curious if we should display a graph with 0 data or with an empty state ("No data available"). Currently, it's not aligned between 2 graphs. We need to finalize and use the same approach in both. What do you think? Btw, there is no dummy bar in empty state.

initial commit

1c9dca3

alaca requested a review from iamdharmesh April 21, 2026 14:27

iamdharmesh changed the base branch from feature/data-layer-and-form-event-tracking to feature/200 April 21, 2026 16:44

iamdharmesh requested a review from Copilot April 21, 2026 16:47

iamdharmesh assigned alaca Apr 21, 2026

iamdharmesh added this to the 2.1.0 milestone Apr 21, 2026

Copilot started reviewing on behalf of iamdharmesh April 21, 2026 16:47 View session

Copilot AI reviewed Apr 21, 2026

View reviewed changes

alaca added 3 commits April 22, 2026 11:35

refactor: match design in figma

91670ca

refactor: suggestions from copilot

6a9b7b0

feature: form performance test

9fa31ea

iamdharmesh requested a review from Copilot April 22, 2026 09:41

Copilot started reviewing on behalf of iamdharmesh April 22, 2026 09:41 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread tests/cypress/e2e/settings/analytics.test.js

Comment thread includes/class-mailchimp-form-performance.php

Comment thread includes/class-mailchimp-form-performance.php

Comment thread includes/class-mailchimp-form-performance.php Outdated

alaca and others added 4 commits April 22, 2026 11:48

Update includes/class-mailchimp-form-performance.php

c19b87e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

feature: add missing helper

d5cda22

Merge remote-tracking branch 'origin/feature/form-performance-chart' …

42e1a2f

…into feature/form-performance-chart

fix: php 7

52b693a

iamdharmesh reviewed Apr 24, 2026

View reviewed changes

Comment thread assets/css/analytics.scss

Comment thread includes/class-mailchimp-form-performance.php

Comment thread includes/class-mailchimp-form-performance.php Outdated

iamdharmesh marked this pull request as draft April 24, 2026 16:27

iamdharmesh linked an issue Apr 24, 2026 that may be closed by this pull request

[Simple Analytics] Performance Summary & Website Form Performance Chart #199

Open

alaca added 4 commits April 28, 2026 10:00

refactor: bump php version to 7.4

7191a8d

refactor: merge shared styles

9b3479f

feature: add Mailchimp_Analytics_Bucketing trait

db0d569

refactor: use Mailchimp_Analytics_Bucketing trait

329ba94

alaca marked this pull request as ready for review April 28, 2026 08:05

iamdharmesh requested a review from Copilot April 30, 2026 12:38

Copilot started reviewing on behalf of iamdharmesh April 30, 2026 12:39 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

iamdharmesh reviewed Apr 30, 2026

View reviewed changes

Conversation

alaca commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the Change

How to test the Change

Changelog Entry

Credits

Checklist:

Uh oh!

alaca commented Apr 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iamdharmesh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

iamdharmesh left a comment

Choose a reason for hiding this comment

Uh oh!

iamdharmesh Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alaca commented Apr 21, 2026 •

edited

Loading