Skip to content

Flatten tree - #950

Open
polycatenane wants to merge 1 commit into
mahkoh:masterfrom
polycatenane:flatten_tree
Open

Flatten tree#950
polycatenane wants to merge 1 commit into
mahkoh:masterfrom
polycatenane:flatten_tree

Conversation

@polycatenane

Copy link
Copy Markdown
Contributor

closes #944

Comment thread jay-config/src/_private/ipc.rs Outdated
@mahkoh

mahkoh commented May 18, 2026

Copy link
Copy Markdown
Owner

Please make this a tristate Never, Always, OnRemove where OnRemove only takes effect when the second-to-last child of a container is removed.

This requires adding a non_exhaustive enum to jay-config and a corresponding enum in Jay proper.

I think this should also be under the [theme] table in the toml config.

You also have to add a corresponding setting in the look-and-feel pane in the control center.

@polycatenane

Copy link
Copy Markdown
Contributor Author

Is the difference between Always and OnRemove that OnRemove lets you manually nest a single child deep in a tree? Always should be closest to how i3 behaves.

@mahkoh

mahkoh commented May 19, 2026

Copy link
Copy Markdown
Owner

Is the difference between Always and OnRemove that OnRemove lets you manually nest a single child deep in a tree?

Yes.

Comment thread jay-config/src/_private/ipc.rs Outdated
Comment thread src/tree/container.rs Outdated
Comment thread src/tree/container.rs Outdated
Comment thread src/tree/container.rs Outdated
Comment thread src/tree/container.rs Outdated
Comment thread src/tree/toplevel.rs Outdated
Comment thread src/compositor.rs Outdated
Comment thread src/state.rs Outdated
Comment thread src/state.rs Outdated
Comment thread toml-config/src/config/parsers/config.rs Outdated
Comment thread toml-spec/spec/spec.yaml Outdated
@polycatenane
polycatenane force-pushed the flatten_tree branch 3 times, most recently from 5adc204 to 2e3f7b0 Compare August 30, 2026 10:21
@mahkoh

mahkoh commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Please follow the style of the rest of the codebase. Also squash the commits as appropriate.

@polycatenane
polycatenane force-pushed the flatten_tree branch 2 times, most recently from 3aa2b4a to 3d336c8 Compare August 30, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flatten container tree

2 participants