Repository navigation
agy-cli 0.1.114: a turn left empty after agy's own tool was turned away is asked again, not a silent stop (#1464) - #1468
Open
wangbingnan136 wants to merge 3 commits into
Conversation
…ked again, not a silent stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1464.
Summary
A step whose only output was calls to agy's own tools, turned away by the bridge, ended the turn with no text and no tool call.
emptyEndingdidn't count it as empty (no thinking, no invalid-output retry), so the client got a finished reply that said nothing.agy told the model "Do not attempt to circumvent this denial … or accessing the same target resource". So the ask says that the same action is allowed through the
mcp_ide-tools_*tools. It names no product (the words sent upstream name nobody).emptyAskedalso makes a bare empty answer to the bridge's own ask an error, where before it passed as a reply.test/testkit.mjsgainsagent.requestPermission(toolCall, options), so the fake agy can ask before one of its own tools, as agy does.Evidence
New tests in
test/repeat-batch.mjs, modelled on #1464's turn:index.mjsviaAGY_BRIDGE_TEST_INDEX): both fail. The response isend_turnwith nothing, and no error.After: pass
read_fileis still denied, the turn is asked once more in the same session, and the client gets theReadcallbun test ./agy-cli.test.mjs,bun scripts/check.mjs,bun scripts/bumped.mjs upstream/main: passNot verified against a real agy: whether the model follows the ask after agy's own denial text.
Merge Danger
Door: two-way.
Blast Radius: narrow. Only turns that end with nothing said after a denial, or after the bridge's own ask, change, from a silent empty reply to one more prompt or an error. Permissions are answered exactly as before.
Version: 0.1.113 → 0.1.114.