Repository navigation
agy-cli 0.1.114: agy's closing "agent executor error" line fails the turn, not a 200 reply (#1326) - #1467
Open
wangbingnan136 wants to merge 1 commit into
Conversation
…turn, not a 200 reply (magpie-community#1326)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1326.
Summary
agy ends a turn whose executor failed with one line,
⚠ agent executor error: <detail>, thenend_turn, so Pi recorded the failed turn as a normal stop. The line is now an ending matched by its start, as the quota and high-traffic endings are. As a line of its own that nothing follows at the end of the prompt, it fails the turn through#formatAgentError(detail). The model quoting it, inline or followed by more text, keeps it.The error reads
agy bridge: agy stopped the turn because of an error: agent executor error: request failed: Bad Gateway, the same form a logged executor error already gets. A 429 in the detail still maps to a rate limit there.Evidence
New tests in
test/repeat-batch.mjs, with the issue's bytes:index.mjsviaAGY_BRIDGE_TEST_INDEX):plugins#1326: agy's agent executor error ending fails the turnfails, and the line arrives as reply textAfter: pass. It covers the line after text, split across chunks, as the whole reply, and after a retry banner.
plugins#1326: the model quoting agy's executor error keeps it: passes before and after.bun test ./agy-cli.test.mjs,bun scripts/check.mjs,bun scripts/bumped.mjs upstream/main: passMerge Danger
Door: two-way.
Blast Radius: narrow. Only a closing line starting
⚠ agent executor error:changes, from a 200 reply to a failed turn.⚠ UNAUTHENTICATED (code 401)-style status lines are left to #1418 / #1296.Version: 0.1.113 → 0.1.114.