Skip to content

agy-cli 0.1.114: agy's closing "agent executor error" line fails the turn, not a 200 reply (#1326) - #1467

Open
wangbingnan136 wants to merge 1 commit into
magpie-community:mainfrom
wangbingnan136:codex/agy-cli-executor-error-ending
Open

wangbingnan136 wants to merge 1 commit into
magpie-community:mainfrom
wangbingnan136:codex/agy-cli-executor-error-ending

Conversation

@wangbingnan136

Copy link
Copy Markdown

Fixes #1326.

Summary

agy ends a turn whose executor failed with one line, ⚠ agent executor error: <detail>, then end_turn, so Pi recorded the failed turn as a normal stop. The line is now an ending matched by its start, as the quota and high-traffic endings are. As a line of its own that nothing follows at the end of the prompt, it fails the turn through #formatAgentError(detail). The model quoting it, inline or followed by more text, keeps it.

 endText()
   AGENT_ERROR_CORES | QUOTA_CORE | BUSY_CORE
+  | EXECUTOR_CORE  → agentError, quotaNotice = detail
 #agentError()
+  EXECUTOR_CORE → #formatAgentError(detail)

The error reads agy bridge: agy stopped the turn because of an error: agent executor error: request failed: Bad Gateway, the same form a logged executor error already gets. A 429 in the detail still maps to a rate limit there.

Evidence

New tests in test/repeat-batch.mjs, with the issue's bytes:

  • Before (upstream index.mjs via AGY_BRIDGE_TEST_INDEX): plugins#1326: agy's agent executor error ending fails the turn fails, and the line arrives as reply text
    After: pass. It covers the line after text, split across chunks, as the whole reply, and after a retry banner.
  • plugins#1326: the model quoting agy's executor error keeps it: passes before and after.
  • bun test ./agy-cli.test.mjs, bun scripts/check.mjs, bun scripts/bumped.mjs upstream/main: pass

Merge Danger

Door: two-way.

Blast Radius: narrow. Only a closing line starting ⚠ agent executor error: changes, from a 200 reply to a failed turn. ⚠ UNAUTHENTICATED (code 401)-style status lines are left to #1418 / #1296.

Version: 0.1.113 → 0.1.114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agy-cli 0.1.95: terminal agent executor error reaches the client as a successful reply

2 participants