Repository navigation
forge-gitlab: Fix template loading - #883
Merged
Merged
Conversation
[1: a6dec70] introduced a bug in resolving Gitlab template paths that causes `forge-pull' to fail for repositories with issue or merge request templates. - Reference the full file path when reading. - Read from the default branch instead of the local working tree. Closes magit#881. 1: 2026-10-20 a6dec70 Get topic template using API and store in database
tarsius
force-pushed
the
fix-gitlab-template-loading
branch
from
November 5, 2026 16:49
dd3b0dc to
94958ba
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a6dec70 introduced a bug in resolving Gitlab template paths that causes
forge-pullto fail for repositories with issue or merge request templates. You can see the issue demonstrated with this repository: https://gitlab.com/mjhoy/repro-forge-issueThis fix has two parts:
Reference the full file path when reading (e.g., .gitlab/issue_templates/Default.md instead of Default.md)
Read from the default branch instead of the local working tree (e.g.,
git cat-file -p origin/main:[PATH]instead ofcat [PATH].)Tested against the repro.
Closes #881.