Repository navigation
Resolve DXCC country when live-logging FT4 and Terminal QSOs - #180
Merged
Merged
Conversation
LiveQsoLogger now uses IDxccLookupService when building QsoRecordCreateRequest, matching the manual logbook path so Country and ADIF DXCC are stored immediately. Fixes #179 Co-authored-by: Peter Goodhall <magicbug@users.noreply.github.com>
magicbug
marked this pull request as ready for review
October 22, 2026 10:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FT4 and Terminal QSOs logged automatically via
LiveQsoLoggerwere persisted withoutDxccandCountry, so the logbook Country column stayed empty and ADIF export omittedCOUNTRYuntil background backfill ran. Manual logbook entry already resolved DXCC at save time viaQsoLogbookViewModel.ResolveDxccFields.Fix
IDxccLookupServiceintoLiveQsoLoggerand populateDxcc/CountryonQsoRecordCreateRequestbeforeAddQsoAsync.IQsoLogbookRepository.QsosChanged, whichAddQsoAsyncraises, so the list refreshes without a restart once country is stored on the new row.Tests
LiveQsoLoggerTestscovering DXCC persistence, unresolved callsigns, andQsosChangednotification.OscarWatch.Testssuite passes locally.Fixes #179