fix(workflows): emit <file> for .php entries in Mage-OS testsuite#372
Merged
mage-os-ci merged 1 commit intoMay 17, 2026
Merged
Conversation
PHPUnit 12 validates is_dir() strictly, so wrapping standalone test files (e.g. STANDALONE_TESTS entries ending in .php) in <directory> fails. Branch on the .php suffix to emit <file> instead, and trim whitespace introduced by JSON formatting before checking. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mage-OS Suitetestsuite.STANDALONE_TESTSshards are single.phpfiles (e.g../testsuite/Magento/Catalog/Model/CategoryTest.php), but the loop unconditionally wrapped every entry in<directory>...</directory>.is_dir()validation on<directory>paths, so the file-as-directory entries now fail the suite definition..phpsuffix to emit<file>for those entries and keep<directory>for everything else. Also trim any whitespace the JSON formatting may leave around each entry before the check.Test plan
Full Integration Testsworkflow runs without PHPUnit configuration errors on the standalone-test shards (e.g.MassScheduleTest.php,CategoryTest.php).Debug:output forNEW_TESTSUITE_ENTRYand confirm.phpshards appear as<file>and directory shards remain<directory>.🤖 Generated with Claude Code