refactor: inline list attribute helpers into onSetUserAttributeList

denischilik · denischilik · commit 193eed5ae1ae · 2026-03-31T15:09:58.000-04:00
- Braze: remove private setUserAttributeList; duplicate Braze getCurrentUser
  flow in onSetUserAttributeList and setAllUserAttributes initial sync.
- Localytics: call Localytics.setProfileAttribute directly from
  onSetUserAttributeList and setAllUserAttributes.

Made-with: Cursor
diff --git a/kits/braze/braze-38/src/main/kotlin/com/mparticle/kits/AppboyKit.kt b/kits/braze/braze-38/src/main/kotlin/com/mparticle/kits/AppboyKit.kt
@@ -440,27 +440,6 @@ open class AppboyKit :
         }
     }
 
-    private fun setUserAttributeList(
-        key: String,
-        list: List<String>,
-    ) {
-        Braze
-            .getInstance(context)
-            .getCurrentUser(
-                object : IValueCallback<BrazeUser> {
-                    override fun onSuccess(value: BrazeUser) {
-                        val array = list.toTypedArray<String?>()
-                        value.setCustomAttributeArray(key, array)
-                        queueDataFlush()
-                    }
-
-                    override fun onError() {
-                        Logger.warning("unable to set key: " + key + " with User Attribute List: " + list)
-                    }
-                },
-            )
-    }
-
     override fun onIncrementUserAttribute(
         key: String?,
         incrementedBy: Number?,
@@ -532,7 +511,23 @@ open class AppboyKit :
         if (attributeKey == null || attributeValueList == null) {
             return
         }
-        setUserAttributeList(attributeKey, attributeValueList)
+        Braze
+            .getInstance(context)
+            .getCurrentUser(
+                object : IValueCallback<BrazeUser> {
+                    override fun onSuccess(value: BrazeUser) {
+                        val array = attributeValueList.toTypedArray<String?>()
+                        value.setCustomAttributeArray(attributeKey, array)
+                        queueDataFlush()
+                    }
+
+                    override fun onError() {
+                        Logger.warning(
+                            "unable to set key: " + attributeKey + " with User Attribute List: " + attributeValueList,
+                        )
+                    }
+                },
+            )
     }
 
     override fun onSetAllUserAttributes(
@@ -689,7 +684,21 @@ open class AppboyKit :
                 applyScalarUserAttribute(key, value)
             }
             for ((key, value) in attributeLists) {
-                setUserAttributeList(key, value)
+                Braze
+                    .getInstance(context)
+                    .getCurrentUser(
+                        object : IValueCallback<BrazeUser> {
+                            override fun onSuccess(brazeUser: BrazeUser) {
+                                val array = value.toTypedArray<String?>()
+                                brazeUser.setCustomAttributeArray(key, array)
+                                queueDataFlush()
+                            }
+
+                            override fun onError() {
+                                Logger.warning("unable to set key: " + key + " with User Attribute List: " + value)
+                            }
+                        },
+                    )
             }
             kitPreferences.edit().putBoolean(PREF_KEY_HAS_SYNCED_ATTRIBUTES, true).apply()
         }
diff --git a/kits/braze/braze-39/src/main/kotlin/com/mparticle/kits/AppboyKit.kt b/kits/braze/braze-39/src/main/kotlin/com/mparticle/kits/AppboyKit.kt
@@ -440,27 +440,6 @@ open class AppboyKit :
         }
     }
 
-    private fun setUserAttributeList(
-        key: String,
-        list: List<String>,
-    ) {
-        Braze
-            .getInstance(context)
-            .getCurrentUser(
-                object : IValueCallback<BrazeUser> {
-                    override fun onSuccess(value: BrazeUser) {
-                        val array = list.toTypedArray<String?>()
-                        value.setCustomAttributeArray(key, array)
-                        queueDataFlush()
-                    }
-
-                    override fun onError() {
-                        Logger.warning("unable to set key: " + key + " with User Attribute List: " + list)
-                    }
-                },
-            )
-    }
-
     override fun onIncrementUserAttribute(
         key: String?,
         incrementedBy: Number?,
@@ -532,7 +511,23 @@ open class AppboyKit :
         if (attributeKey == null || attributeValueList == null) {
             return
         }
-        setUserAttributeList(attributeKey, attributeValueList)
+        Braze
+            .getInstance(context)
+            .getCurrentUser(
+                object : IValueCallback<BrazeUser> {
+                    override fun onSuccess(value: BrazeUser) {
+                        val array = attributeValueList.toTypedArray<String?>()
+                        value.setCustomAttributeArray(attributeKey, array)
+                        queueDataFlush()
+                    }
+
+                    override fun onError() {
+                        Logger.warning(
+                            "unable to set key: " + attributeKey + " with User Attribute List: " + attributeValueList,
+                        )
+                    }
+                },
+            )
     }
 
     override fun onSetAllUserAttributes(
@@ -689,7 +684,21 @@ open class AppboyKit :
                 applyScalarUserAttribute(key, value)
             }
             for ((key, value) in attributeLists) {
-                setUserAttributeList(key, value)
+                Braze
+                    .getInstance(context)
+                    .getCurrentUser(
+                        object : IValueCallback<BrazeUser> {
+                            override fun onSuccess(brazeUser: BrazeUser) {
+                                val array = value.toTypedArray<String?>()
+                                brazeUser.setCustomAttributeArray(key, array)
+                                queueDataFlush()
+                            }
+
+                            override fun onError() {
+                                Logger.warning("unable to set key: " + key + " with User Attribute List: " + value)
+                            }
+                        },
+                    )
             }
             kitPreferences.edit().putBoolean(PREF_KEY_HAS_SYNCED_ATTRIBUTES, true).apply()
         }
diff --git a/kits/braze/braze-40/src/main/kotlin/com/mparticle/kits/AppboyKit.kt b/kits/braze/braze-40/src/main/kotlin/com/mparticle/kits/AppboyKit.kt
@@ -440,27 +440,6 @@ open class AppboyKit :
         }
     }
 
-    private fun setUserAttributeList(
-        key: String,
-        list: List<String>,
-    ) {
-        Braze
-            .getInstance(context)
-            .getCurrentUser(
-                object : IValueCallback<BrazeUser> {
-                    override fun onSuccess(value: BrazeUser) {
-                        val array = list.toTypedArray<String?>()
-                        value.setCustomAttributeArray(key, array)
-                        queueDataFlush()
-                    }
-
-                    override fun onError() {
-                        Logger.warning("unable to set key: " + key + " with User Attribute List: " + list)
-                    }
-                },
-            )
-    }
-
     override fun onIncrementUserAttribute(
         key: String?,
         incrementedBy: Number?,
@@ -532,7 +511,23 @@ open class AppboyKit :
         if (attributeKey == null || attributeValueList == null) {
             return
         }
-        setUserAttributeList(attributeKey, attributeValueList)
+        Braze
+            .getInstance(context)
+            .getCurrentUser(
+                object : IValueCallback<BrazeUser> {
+                    override fun onSuccess(value: BrazeUser) {
+                        val array = attributeValueList.toTypedArray<String?>()
+                        value.setCustomAttributeArray(attributeKey, array)
+                        queueDataFlush()
+                    }
+
+                    override fun onError() {
+                        Logger.warning(
+                            "unable to set key: " + attributeKey + " with User Attribute List: " + attributeValueList,
+                        )
+                    }
+                },
+            )
     }
 
     override fun onSetAllUserAttributes(
@@ -689,7 +684,21 @@ open class AppboyKit :
                 applyScalarUserAttribute(key, value)
             }
             for ((key, value) in attributeLists) {
-                setUserAttributeList(key, value)
+                Braze
+                    .getInstance(context)
+                    .getCurrentUser(
+                        object : IValueCallback<BrazeUser> {
+                            override fun onSuccess(brazeUser: BrazeUser) {
+                                val array = value.toTypedArray<String?>()
+                                brazeUser.setCustomAttributeArray(key, array)
+                                queueDataFlush()
+                            }
+
+                            override fun onError() {
+                                Logger.warning("unable to set key: " + key + " with User Attribute List: " + value)
+                            }
+                        },
+                    )
             }
             kitPreferences.edit().putBoolean(PREF_KEY_HAS_SYNCED_ATTRIBUTES, true).apply()
         }
diff --git a/kits/braze/braze-41/src/main/kotlin/com/mparticle/kits/AppboyKit.kt b/kits/braze/braze-41/src/main/kotlin/com/mparticle/kits/AppboyKit.kt
@@ -440,27 +440,6 @@ open class AppboyKit :
         }
     }
 
-    private fun setUserAttributeList(
-        key: String,
-        list: List<String>,
-    ) {
-        Braze
-            .getInstance(context)
-            .getCurrentUser(
-                object : IValueCallback<BrazeUser> {
-                    override fun onSuccess(value: BrazeUser) {
-                        val array = list.toTypedArray<String?>()
-                        value.setCustomAttributeArray(key, array)
-                        queueDataFlush()
-                    }
-
-                    override fun onError() {
-                        Logger.warning("unable to set key: " + key + " with User Attribute List: " + list)
-                    }
-                },
-            )
-    }
-
     override fun onIncrementUserAttribute(
         key: String?,
         incrementedBy: Number?,
@@ -532,7 +511,23 @@ open class AppboyKit :
         if (attributeKey == null || attributeValueList == null) {
             return
         }
-        setUserAttributeList(attributeKey, attributeValueList)
+        Braze
+            .getInstance(context)
+            .getCurrentUser(
+                object : IValueCallback<BrazeUser> {
+                    override fun onSuccess(value: BrazeUser) {
+                        val array = attributeValueList.toTypedArray<String?>()
+                        value.setCustomAttributeArray(attributeKey, array)
+                        queueDataFlush()
+                    }
+
+                    override fun onError() {
+                        Logger.warning(
+                            "unable to set key: " + attributeKey + " with User Attribute List: " + attributeValueList,
+                        )
+                    }
+                },
+            )
     }
 
     override fun onSetAllUserAttributes(
@@ -689,7 +684,21 @@ open class AppboyKit :
                 applyScalarUserAttribute(key, value)
             }
             for ((key, value) in attributeLists) {
-                setUserAttributeList(key, value)
+                Braze
+                    .getInstance(context)
+                    .getCurrentUser(
+                        object : IValueCallback<BrazeUser> {
+                            override fun onSuccess(brazeUser: BrazeUser) {
+                                val array = value.toTypedArray<String?>()
+                                brazeUser.setCustomAttributeArray(key, array)
+                                queueDataFlush()
+                            }
+
+                            override fun onError() {
+                                Logger.warning("unable to set key: " + key + " with User Attribute List: " + value)
+                            }
+                        },
+                    )
             }
             kitPreferences.edit().putBoolean(PREF_KEY_HAS_SYNCED_ATTRIBUTES, true).apply()
         }
diff --git a/kits/localytics/localytics-6/src/main/kotlin/com/mparticle/kits/LocalyticsKit.kt b/kits/localytics/localytics-6/src/main/kotlin/com/mparticle/kits/LocalyticsKit.kt
@@ -148,20 +148,12 @@ class LocalyticsKit :
         }
     }
 
-    private fun setUserAttributeList(
-        key: String,
-        list: List<String>,
-    ) {
-        val array = list.toTypedArray()
-        Localytics.setProfileAttribute(key, array)
-    }
-
     override fun onSetUserAttributeList(
         attributeKey: String,
         attributeValueList: List<String>,
         user: FilteredMParticleUser,
     ) {
-        setUserAttributeList(attributeKey, attributeValueList)
+        Localytics.setProfileAttribute(attributeKey, attributeValueList.toTypedArray())
     }
 
     override fun supportsAttributeLists(): Boolean = true
@@ -174,7 +166,7 @@ class LocalyticsKit :
             applyScalarUserAttribute(key, value)
         }
         for ((key, value) in attributeLists) {
-            setUserAttributeList(key, value)
+            Localytics.setProfileAttribute(key, value.toTypedArray())
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -148,20 +148,12 @@ class LocalyticsKit :`
`148`	`148`	`}`
`149`	`149`	`}`
`150`	`150`
`151`		`- private fun setUserAttributeList(`
`152`		`- key: String,`
`153`		`- list: List<String>,`
`154`		`- ) {`
`155`		`- val array = list.toTypedArray()`
`156`		`- Localytics.setProfileAttribute(key, array)`
`157`		`- }`
`158`		`-`
`159`	`151`	`override fun onSetUserAttributeList(`
`160`	`152`	`attributeKey: String,`
`161`	`153`	`attributeValueList: List<String>,`
`162`	`154`	`user: FilteredMParticleUser,`
`163`	`155`	`) {`
`164`		`- setUserAttributeList(attributeKey, attributeValueList)`
	`156`	`+ Localytics.setProfileAttribute(attributeKey, attributeValueList.toTypedArray())`
`165`	`157`	`}`
`166`	`158`
`167`	`159`	`override fun supportsAttributeLists(): Boolean = true`
`@@ -174,7 +166,7 @@ class LocalyticsKit :`
`174`	`166`	`applyScalarUserAttribute(key, value)`
`175`	`167`	`}`
`176`	`168`	`for ((key, value) in attributeLists) {`
`177`		`- setUserAttributeList(key, value)`
	`169`	`+ Localytics.setProfileAttribute(key, value.toTypedArray())`
`178`	`170`	`}`
`179`	`171`	`}`
`180`	`172`