refactor: remove setUserAttributeList from AttributeListener

- Drop legacy two-arg setUserAttributeList from KitIntegration.AttributeListener;
  KitManagerImpl already forwards list attributes via onSetUserAttributeList.
- Kits: use private helpers (Braze, Localytics) or inline no-ops; Adobe kits call
  syncIds from onSetUserAttributeList only.
- AttributeListenerTestKit invokes list callback from onSetUserAttributeList.

Made-with: Cursor

Author: denischilik

android-kit-base/src/androidTest/kotlin/com/mparticle/kits/testkits/AttributeListenerTestKit.kt

@@ -24,20 +24,13 @@ open class AttributeListenerTestKit :
 
     override fun supportsAttributeLists() = supportsAttributeLists?.invoke() ?: true
 
-    override fun setUserAttributeList(
-        attributeKey: String,
-        attributeValueList: MutableList<String>,
-    ) {
-        setUserAttributeList?.invoke(attributeKey, attributeValueList)
-        onAttributeReceived?.invoke(attributeKey, attributeValueList)
-    }
-
     override fun onSetUserAttributeList(
         attributeKey: String,
         attributeValueList: List<String>,
         user: FilteredMParticleUser,
     ) {
-        setUserAttributeList(attributeKey, attributeValueList.toMutableList())
+        setUserAttributeList?.invoke(attributeKey, attributeValueList)
+        onAttributeReceived?.invoke(attributeKey, attributeValueList)
     }
 
     override fun setAllUserAttributes(

android-kit-base/src/main/java/com/mparticle/kits/KitIntegration.java

@@ -409,8 +409,6 @@ public interface BaseAttributeListener {
 
     public interface AttributeListener extends BaseAttributeListener {
 
-        void setUserAttributeList(String attributeKey, List<String> attributeValueList);
-
         void setAllUserAttributes(Map<String, String> userAttributes, Map<String, List<String>> userAttributeLists);
 
         void setUserIdentity(MParticle.IdentityType identityType, String identity);

kits/adobe/adobe-5/src/main/kotlin/com/mparticle/kits/AdobeKitBase.kt

@@ -48,19 +48,12 @@ abstract class AdobeKitBase :
         syncIds()
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
-    ) {
-        syncIds()
-    }
-
     override fun onSetUserAttributeList(
         attributeKey: String,
         attributeValueList: List<String>,
         user: FilteredMParticleUser,
     ) {
-        setUserAttributeList(attributeKey, attributeValueList)
+        syncIds()
     }
 
     override fun supportsAttributeLists(): Boolean = false

kits/adobemedia/adobemedia-5/src/main/kotlin/com/mparticle/kits/AdobeKit.kt

@@ -85,19 +85,12 @@ open class AdobeKit :
         syncIds()
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
-    ) {
-        syncIds()
-    }
-
     override fun onSetUserAttributeList(
         attributeKey: String,
         attributeValueList: List<String>,
         user: FilteredMParticleUser,
     ) {
-        setUserAttributeList(attributeKey, attributeValueList)
+        syncIds()
     }
 
     override fun supportsAttributeLists(): Boolean = false

kits/appsflyer/appsflyer-6/src/main/kotlin/com/mparticle/kits/AppsFlyerKit.kt

@@ -248,11 +248,6 @@ class AppsFlyerKit :
         return messageList
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
-    ) {}
-
     override fun onIncrementUserAttribute(
         key: String?,
         incrementedBy: Number?,

kits/apptimize/apptimize-3/src/main/kotlin/com/mparticle/kits/ApptimizeKit.kt

@@ -121,22 +121,12 @@ class ApptimizeKit :
 
     override fun getName(): String = KIT_NAME
 
-    /**
-     * Not supported by the Apptimize kit.
-     */
-    override fun setUserAttributeList(
-        key: String,
-        list: List<String>,
-    ) {
-        // not supported
-    }
-
     override fun onSetUserAttributeList(
         attributeKey: String,
         attributeValueList: List<String>,
         user: FilteredMParticleUser,
     ) {
-        setUserAttributeList(attributeKey, attributeValueList)
+        // not supported by the Apptimize kit
     }
 
     override fun supportsAttributeLists(): Boolean = false

kits/branch/branch-5/src/main/kotlin/com/mparticle/kits/BranchMetricsKit.kt

@@ -174,17 +174,11 @@ class BranchMetricsKit :
         )
     }
 
-    override fun setUserAttributeList(
-        s: String,
-        list: List<String>,
-    ) {}
-
     override fun onSetUserAttributeList(
         attributeKey: String,
         attributeValueList: List<String>,
         user: FilteredMParticleUser,
     ) {
-        setUserAttributeList(attributeKey, attributeValueList)
     }
 
     override fun supportsAttributeLists(): Boolean = true

kits/braze/braze-38/src/main/kotlin/com/mparticle/kits/AppboyKit.kt

@@ -440,7 +440,7 @@ open class AppboyKit :
         }
     }
 
-    override fun setUserAttributeList(
+    private fun setUserAttributeList(
         key: String,
         list: List<String>,
     ) {

kits/braze/braze-39/src/main/kotlin/com/mparticle/kits/AppboyKit.kt

@@ -440,7 +440,7 @@ open class AppboyKit :
         }
     }
 
-    override fun setUserAttributeList(
+    private fun setUserAttributeList(
         key: String,
         list: List<String>,
     ) {

kits/braze/braze-40/src/main/kotlin/com/mparticle/kits/AppboyKit.kt

@@ -440,7 +440,7 @@ open class AppboyKit :
         }
     }
 
-    override fun setUserAttributeList(
+    private fun setUserAttributeList(
         key: String,
         list: List<String>,
     ) {