Repository navigation
Fix macOS release test and release Agent 0.5.1 - #293
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.5.0 macOS release build failed because its file-link test assumed the absolute temporary path fit in an 80-column row. macOS uses longer temporary paths, so the renderer correctly emitted a link on each wrapped row.
Give the single-row assertion enough width for its fixture and explicitly check that wrapped rows all open the same file. Bump all three crates and the lockfile to 0.5.1 so the corrected release preserves the already-pushed 0.5.0 tag. This includes all planned 0.5.0 changes.
Validation: reproduced the original assertion on macOS and confirmed it passed with a short TMPDIR; the corrected test passes with both paths, all seven link tests pass, and the full Sonny unit suite passes (313 passed, one existing ignored test). cargo metadata --offline --locked, cargo fmt --check, and git diff --check pass.