Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
The telemetry correction and behavioral regression coverage have been carried into the current integration submission, with validation limitations documented there. Closing this personal tracking PR to avoid duplicate implementation and follow-up work. |
Motivation
CodexWsStageRecordsnapshot when the response committed, so logs adopted that initial object and later stream settlements could replace the WeakMap entry without updating the already-adopted attempt, producing stale telemetry ([Bug]: Long Codex thread fails only through OpenCodex proxy (WS 1006 / response prelude timeout); bypass works immediately lidge-jun/opencodex#4191).Description
markCodexWsStageto update an existing record in-place (viaObject.assign) when one is already mapped to theResponse, preserving the reference held by logging paths instead of replacing it; this is implemented insrc/server/responses/codex-ws-wire.ts.markCodexWsStagecalls finalize the object already adopted by the logger (tests/responses/ws-failure-stage.test.ts).structure/transports/responses.md).Testing
mise x bun@1.4.2 -- bun test tests/responses/ws-failure-stage.test.ts, which passed all tests (15 passed, 0 failed).mise x bun@1.4.2 -- bun run structure:check,mise x bun@1.4.2 -- bun run privacy:scan, andmise x bun@1.4.2 -- bun run typecheck, all of which succeeded.bun run testwas started but interrupted by unrelated existing catalog-route test expectations (not caused by these changes); the focused regression and validation checks above are green.Codex Task