Skip to content

fix(responses): finalize WebSocket stage telemetry in place - #541

Closed
luvs01 wants to merge 1 commit into
devfrom
codex/propose-fix-for-websocket-stage-logs-issue
Closed

luvs01 wants to merge 1 commit into
devfrom
codex/propose-fix-for-websocket-stage-logs-issue

Conversation

@luvs01

@luvs01 luvs01 commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Motivation

Description

  • Change markCodexWsStage to update an existing record in-place (via Object.assign) when one is already mapped to the Response, preserving the reference held by logging paths instead of replacing it; this is implemented in src/server/responses/codex-ws-wire.ts.
  • Add a regression test that verifies later markCodexWsStage calls finalize the object already adopted by the logger (tests/responses/ws-failure-stage.test.ts).
  • Update the transport documentation to describe the invariant that stream settlements finalize the same stage object in place (structure/transports/responses.md).

Testing

  • Ran the focused WebSocket regression tests with Bun v1.4.2: mise x bun@1.4.2 -- bun test tests/responses/ws-failure-stage.test.ts, which passed all tests (15 passed, 0 failed).
  • Ran repository validation steps: mise x bun@1.4.2 -- bun run structure:check, mise x bun@1.4.2 -- bun run privacy:scan, and mise x bun@1.4.2 -- bun run typecheck, all of which succeeded.
  • A full bun run test was started but interrupted by unrelated existing catalog-route test expectations (not caused by these changes); the focused regression and validation checks above are green.

Codex Task

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7cf79a85-f6a9-4910-9ca5-7f922fe8dbfd


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 14, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T06:39:00.252563Z 169f178 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@luvs01

luvs01 commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

The telemetry correction and behavioral regression coverage have been carried into the current integration submission, with validation limitations documented there. Closing this personal tracking PR to avoid duplicate implementation and follow-up work.

@luvs01 luvs01 closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant