Conversation
…43-01a07240 [WRONG BRANCH] chore(release): promote verified candidate to 2.43.0
…lease-244-main-07c0
…in-07c0 chore(release): promote validated 2.44.0 to main
Promote frozen dev source cf9f662; no new runtime changes. Candidate CI34061274315 and service34061276621 are the validation references. Publication waits for successful validation and the final main push CI at the exact release SHA.
Promote frozen dev source cf9f662 as 2.45.0. The repository owner explicitly authorized this main/preview release promotion and admin PR-only merge. This is a release-specific owner decision, not an independent approval or the dev-only maintainer exception. Frozen candidate full CI34061274315 passed all25jobs after one unchanged-source rerun of Windows5; the initial holder busy assertion remains recorded without a root-cause resolution claim. Service lifecycle34061276621 passed Linux/macOS/Windows. Dev version pre-move3812 is merged. Publication still requires this actual main merge SHA's own successful push CI and Service lifecycle. No local suites were run.
[WRONG BRANCH] chore(release): promote verified 2.46.0 to main
[WRONG BRANCH] release: promote 2.47.0 to main
[WRONG BRANCH] release: apply final roster correction to main
[WRONG BRANCH] release: promote 2.48.0 to main
…in-01a08498 release: promote verified 2.49.0 product tree to main
…in-01a08a81 [WRONG BRANCH] release: promote verified 2.50.0 product tree to main
[WRONG BRANCH] release: promote verified 2.51.0 product tree to main
Product tree is dev at 7bfb2ad. Only package.json differs, carrying the stable channel version 2.52.0. This promotion follows a CI repair and a regression sweep: dev had drifted 79 commits past its last finished run and the one run allowed to complete had failed. lidge-jun#4390 fixed an integration test that never denied anything and had been red on dev since lidge-jun#4342; lidge-jun#4396/lidge-jun#4397/lidge-jun#4398 closed four gaps in the quota avoidance contract lidge-jun#4368 introduced; lidge-jun#4403 made a port fixture deterministic.
release: promote verified 2.52.0 product tree to main
Product tree is dev at eb81eaa, byte-identical (dev already carries the 2.53.0 version line). This promotion follows a 364-commit regression audit (origin/main..981b53e) by 15 parallel subagent lanes plus two audit-spawned fixes reviewed and merged to dev: lidge-jun#4496 (live sideband connect watchdog) and lidge-jun#4497 (chat image part shapes). Zero unresolved P0/P1 at promotion time. Exact-head hosted CI green on eb81eaa (run 34750934849). Local suite NOT RUN per task rule; hosted exact-head CI is the gate.
[WRONG BRANCH] release: promote verified 2.53.0 product tree to main
Product tree is dev at a84e6e8, byte-identical (dev already carries the 2.54.0 version line). Headed by the Codex model-picker incident fix (lidge-jun#4531). On Codex 0.154.0-alpha.6.2 a paginated-history preflight vetoed the entire Codex config write, so model_catalog_json never reached config.toml and both the Codex app and the CLI fell back to their six built-in models, while ocx sync reported that failure as success. The refusal is now scoped to the conversation-history relabel unit on the apply direction only, narrowed to the one permanent reason, and a provider table the home already published survives the write. Exact-head hosted CI green on a84e6e8 via lidge-jun#4531 (run 34772128322): all four Linux test shards, both macOS shards, gates, hygiene, storage policy, api usage, keyring x3, npm-global x3, docker smoke, react-doctor. Local suite NOT RUN per task rule; hosted exact-head CI is the gate.
[WRONG BRANCH] release: promote verified 2.54.0 product tree to main
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ff044d19b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const { runCodexFeaturesCommand } = await import("../cli/v2"); | ||
| toggle = enabled => runCodexFeaturesCommand(enabled ? "enable" : "disable"); | ||
| } | ||
| const transition = transitionMultiAgentV2(false, toggle); |
There was a problem hiding this comment.
When the persisted integration switches OFF or becomes hub-gated while catalog discovery is in progress—or a connected-client ownership guard becomes stale—this call rewrites config.toml before the fresh desired-state and ownership checks at the actual commit boundary. The later check can therefore return status: "skipped" or throw while the user's global v2 flag and thread-limit storage have already changed, despite reporting that no Codex config was changed. Run this transition under the same gate and locks as the artifact writes and include it in their compensation.
Useful? React with 👍 / 👎.
| // the same format-preserving transition as the explicit CLI/API mode selectors before | ||
| // taking the journal baseline. External provider-owned configs returned above remain | ||
| // byte-for-byte untouched, and read-only preflight remains read-only. | ||
| if (!options.validateOnly && config?.multiAgentMode === "v1") { |
There was a problem hiding this comment.
When v1 injection encounters an enabled v2 configuration that cannot be migrated—for example, an untranslatable stored thread limit or an unsupported dotted multi-agent key—validateOnly skips the transition and reports success. syncModelsToCodex relies on that result before refreshing the catalog and cache, so only the final apply discovers the deterministic refusal, leaving those artifacts updated without a successful config injection. Add a non-mutating validation path that exercises the transition's preconditions during preflight.
Useful? React with 👍 / 👎.
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
changed the title
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
luvs01
changed the title
2 participants
Motivation
multiAgentMode:"v1"and marked the advisory acknowledged without disabling Codex's higher-precedencefeatures.multi_agent_v2, producing an internally inconsistent state where the catalog claimed v1 but Codex could still run v2 and produce unreadable encrypted child tasks.Description
injectCodexConfig(), detect when the requested OpenCodex mode isv1and the nativefeatures.multi_agent_v2is enabled, and run the same format-preserving transition used by CLI/API paths to disable the global V2 feature (seamInjectCodexOptions.toggleCodexMultiAgentV2added to allow test injection without a real Codex runtime). (changes insrc/codex/inject.ts)config.tomlwithfeatures.multi_agent_v2 = true, performs a v1 injection, and asserts the native flag was reconciled tofalseand the injection completed. (changes intests/codex-integration/codex-inject-integration.test.ts)structure/config.mdandstructure/subagents.md)Testing
./node_modules/.bin/bun test tests/codex-integration/codex-inject-integration.test.ts -t 'a v1 injection disables', which passed under the repo Bun runtime.bun run typecheck,bun run structure:check, andbun run privacy:scan, andgit diff --check, all of which passed locally for the change set.bun run test); the repository-wide run completed but the parallel lane in this container reported many unrelated/environment-specific failures (container/runtime and shim-related flakes); the focused regression above and the static checks listed succeeded.Codex Task