Skip to content

fix(devin): suppress untrusted Connect trailer text - #513

Open
luvs01 wants to merge 27 commits into
devfrom
codex/fix-devin-adapter-credential-exposure
Open

luvs01 wants to merge 27 commits into
devfrom
codex/fix-devin-adapter-credential-exposure

Conversation

@luvs01

@luvs01 luvs01 commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Prevent Devin cloud Connect-RPC EOS trailers from propagating upstream-controlled error.message text into adapter error events, API responses, and request/diagnostic logs because those messages can reflect stored provider credentials.

Description

  • Parse Connect trailers with an allowlist for known safe code values and retain only an allowlisted code and a hexadecimal trace id instead of the raw upstream message. (changes in src/adapters/devin/cloud-direct/chat.ts)
  • Stop copying raw trailer message text into CloudChatError; replace it with a content-free diagnostic that includes only the allowed code and trace id while preserving the existing enriched diagnostics for the known opaque-denial and tool-blocklist shapes. (changes in src/adapters/devin/cloud-direct/chat.ts)
  • Add safeConnectCode() and adjust the trailer parsing shape to avoid carrying untrusted message text out of the parser. (changes in src/adapters/devin/cloud-direct/chat.ts)
  • Add a focused regression test that simulates a trailer reflecting a Devin credential and asserts the credential does not appear in the surfaced error. (added tests/providers/devin-hardening.test.ts)
  • Document the adapter diagnostic trust boundary in the registry architecture note. (updated structure/adapters/registry.md)

Testing

  • Ran the focused Devon hardening tests with bun test tests/providers/devin-hardening.test.ts which passed (17 tests, 0 failures).
  • Ran static checks bun run typecheck, bun run structure:check, and bun run privacy:scan, all of which completed successfully against the modified code.
  • The repository-wide bun run test run observed unrelated, existing environment-sensitive failures in other suites (parallel runner panic and container process-group issues) and is not a counterexample to the focused regression results above.

Codex Task

lidge-jun and others added 27 commits September 6, 2026 01:08
…43-01a07240

[WRONG BRANCH] chore(release): promote verified candidate to 2.43.0
…in-07c0

chore(release): promote validated 2.44.0 to main
Promote frozen dev source cf9f662; no new runtime changes. Candidate CI34061274315 and service34061276621 are the validation references. Publication waits for successful validation and the final main push CI at the exact release SHA.
Promote frozen dev source cf9f662 as 2.45.0.

The repository owner explicitly authorized this main/preview release promotion and admin PR-only merge. This is a release-specific owner decision, not an independent approval or the dev-only maintainer exception.

Frozen candidate full CI34061274315 passed all25jobs after one unchanged-source rerun of Windows5; the initial holder busy assertion remains recorded without a root-cause resolution claim. Service lifecycle34061276621 passed Linux/macOS/Windows. Dev version pre-move3812 is merged. Publication still requires this actual main merge SHA's own successful push CI and Service lifecycle. No local suites were run.
[WRONG BRANCH] chore(release): promote verified 2.46.0 to main
[WRONG BRANCH] release: promote 2.47.0 to main
[WRONG BRANCH] release: apply final roster correction to main
[WRONG BRANCH] release: promote 2.48.0 to main
…in-01a08498

release: promote verified 2.49.0 product tree to main
Promotes the audited freeze SHA 12c248f unchanged. The resulting tree is byte-identical to that commit's tree, d8f5a71, so what ships is exactly what the six-lane regression audit read.
…in-01a08a81

[WRONG BRANCH] release: promote verified 2.50.0 product tree to main
[WRONG BRANCH] release: promote verified 2.51.0 product tree to main
Product tree is dev at 7bfb2ad. Only package.json differs, carrying the
stable channel version 2.52.0.

This promotion follows a CI repair and a regression sweep: dev had drifted 79
commits past its last finished run and the one run allowed to complete had
failed. lidge-jun#4390 fixed an integration test that never denied anything and had been
red on dev since lidge-jun#4342; lidge-jun#4396/lidge-jun#4397/lidge-jun#4398 closed four gaps in the quota
avoidance contract lidge-jun#4368 introduced; lidge-jun#4403 made a port fixture deterministic.
release: promote verified 2.52.0 product tree to main
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 22dc5493-a93e-41c9-9db6-963e4eb032ea


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T00:23:41.944923Z 9a3c33d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@luvs01
luvs01 changed the base branch from main to Dev September 14, 2026 00:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9a3c33de59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}

const TRACE_ID_RE = /\(trace ID: ([0-9a-f]+)\)/i;
const SAFE_CONNECT_CODES = new Set([

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update all mapped adapter documents

This changes src/adapters/, but the commit updates only structure/adapters/registry.md; structure/INDEX.md:96 maps this area to six additional documents (runtime.md, the Responses and inventory transport docs, inbound compatibility, Cursor, and chat compatibility). Leaving those documents untouched violates the source-to-doc contract and allows their adapter descriptions to drift, so update every mapped document in this change or correct the ownership map if they do not actually describe this area.

AGENTS.md reference: src/AGENTS.md:L11-L11

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the bug Something isn't working label Sep 14, 2026
@github-actions github-actions Bot changed the title fix(devin): suppress untrusted Connect trailer text [WRONG BRANCH] fix(devin): suppress untrusted Connect trailer text Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

✅ READY

  • all PR quality gates passed.

Hygiene

Deterministic PR hygiene checks passed.

@github-actions
github-actions Bot marked this pull request as draft September 14, 2026 01:02
@luvs01 luvs01 changed the title [WRONG BRANCH] fix(devin): suppress untrusted Connect trailer text fix(devin): suppress untrusted Connect trailer text Sep 16, 2026
@github-actions
github-actions Bot marked this pull request as ready for review September 16, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants