Skip to content

Redact local paths and guard Pages deploys to master - #96

Merged
luinbytes merged 2 commits into
masterfrom
security/sanitize-local-paths-and-deploy-guard
Nov 14, 2026
Merged

luinbytes merged 2 commits into
masterfrom
security/sanitize-local-paths-and-deploy-guard

Conversation

@luinbytes

@luinbytes luinbytes commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Redact 29 machine-specific workspace-path occurrences across the checked-in review artifacts. The existing decision-log file remains in place; with the owner's approval, its private row is replaced by six [REDACTED] cells.
  • Add a refs/heads/master condition to the Pages deployment job so a manual dispatch from another branch cannot deploy.
  • Leave the public privacy notice unchanged.

The workflow condition is a guard against accidental/non-master manual deployments, not a security boundary against someone with repository write access who can change the workflow. Stronger enforcement would require GitHub Pages/environment branch restrictions; this PR does not change those settings.

Verification

  • Checked all 17 changed files on the branch: no /Users/ or Windows user-path strings remain, the decision row is fully redacted, and the guard appears once under the deploy job.
  • GitHub Actions run #52 passed: dependency audit, lint, pond tests, and production browser suite.
  • The full suite was not run locally because the connected checkout is 28 commits behind this branch base and direct GitHub fetch is blocked by the computer's network policy.

@luinbytes
luinbytes marked this pull request as ready for review November 14, 2026 00:29
@luinbytes
luinbytes merged commit c8db57e into master Nov 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant