Skip to content

Remove Pip page and homepage feature - #69

Merged
luinbytes merged 4 commits into
masterfrom
capy/remove-pip-page-and
Nov 5, 2026
Merged

luinbytes merged 4 commits into
masterfrom
capy/remove-pip-page-and

Conversation

@luinbytes

@luinbytes luinbytes commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Changes

  • Remove the Pip homepage card, navigation link, standalone route, metadata, sitemap entry, and Pip-specific assets and build tooling.
  • Retire /pip and /pip.html to the existing 404, retain shared image-loading coverage, and verify exported internal links.

Verification

  • npm run lint
  • npm run test:pond
  • npm run test:e2e (34 tests, including internal-link integrity)
  • Inspected the homepage at 320, 390, and 1440px with reduced motion.

Desktop homepage
Mobile homepage

Open in Capy

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

@luinbytes luinbytes left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review notes. npm ci, npm audit --audit-level=high, lint, build, test:pond and the full e2e suite (33 tests) all pass locally, and /pip and /pip.html 404 cleanly. Some leftovers:

  1. .agents/skills/site-verification/SKILL.md:10,12,13 still tells agents to run npm run test:pip (removed), lists /pip as a sitemap entry, checks out/pip.html, and points at lib/pip.ts. Agents following it will fail or put Pip back.
  2. These screenshots are orphaned and still committed, with nothing referencing them: docs/screenshots/homepage-pip-desktop.png, homepage-pip-mobile.png, pip-button-detail.png, pip-desktop.png, pip-mobile.png.
  3. .gitignore:24 has a leftover /public/qr/ entry. It was only there for the removed scripts/generate-pip-qr.mjs.
  4. components/concepts/signal-desk/signal-desk.module.css:115-116, 786-787, 884-885: removing the .pipNavLink rules left runs of blank lines.
  5. Coverage: test_image_error_clears_the_skeleton_and_shows_the_qr_fallback went with the QR panel. The new homepage SkulletImageTests (tests/browser/browser_test.py:1951) cover the delayed, complete and failed-chunk cases, but not an image error clearing the skeleton. It's worth porting that case to the avatar.
  6. Optional: review-previews/** (ui-stack docs/logs, site-pass-2026-10-23, manifest) still has a lot of Pip material, including QR and social-card artefacts. It isn't deployed.

Merge note: this conflicts with #68 (app/pip/page.tsx, components/pip/pip-feature.tsx modify/delete, plus app/routes.tsx and tests/browser/browser_test.py). I'd suggest landing this first and rebasing #68.

@capy-ai

capy-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Addressed points 1–5 in fdf4e70: updated site-verification guidance, removed the five orphaned screenshots and QR ignore rule, cleaned up CSS whitespace, and added an avatar image-error skeleton regression test. I left review-previews/** intact as historical, non-deployed review evidence. The reported #68 integration overlap remains for coordination; no merge was performed.

luinbytes added a commit that referenced this pull request Nov 5, 2026
@luinbytes
luinbytes merged commit 289aa83 into master Nov 5, 2026
2 checks passed
luinbytes added a commit that referenced this pull request Nov 5, 2026
* Remove Orchid and Keiki references

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Remove unused Orchid artwork

* Drop Orchid previews and leave Pip files to #69

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@luinbytes
luinbytes deleted the capy/remove-pip-page-and branch November 7, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant