Repository navigation
Remove Pip page and homepage feature - #69
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
luinbytes
left a comment
There was a problem hiding this comment.
Review notes. npm ci, npm audit --audit-level=high, lint, build, test:pond and the full e2e suite (33 tests) all pass locally, and /pip and /pip.html 404 cleanly. Some leftovers:
.agents/skills/site-verification/SKILL.md:10,12,13still tells agents to runnpm run test:pip(removed), lists/pipas a sitemap entry, checksout/pip.html, and points atlib/pip.ts. Agents following it will fail or put Pip back.- These screenshots are orphaned and still committed, with nothing referencing them:
docs/screenshots/homepage-pip-desktop.png,homepage-pip-mobile.png,pip-button-detail.png,pip-desktop.png,pip-mobile.png. .gitignore:24has a leftover/public/qr/entry. It was only there for the removedscripts/generate-pip-qr.mjs.components/concepts/signal-desk/signal-desk.module.css:115-116, 786-787, 884-885: removing the.pipNavLinkrules left runs of blank lines.- Coverage:
test_image_error_clears_the_skeleton_and_shows_the_qr_fallbackwent with the QR panel. The new homepageSkulletImageTests(tests/browser/browser_test.py:1951) cover the delayed, complete and failed-chunk cases, but not an imageerrorclearing the skeleton. It's worth porting that case to the avatar. - Optional:
review-previews/**(ui-stack docs/logs, site-pass-2026-10-23, manifest) still has a lot of Pip material, including QR and social-card artefacts. It isn't deployed.
Merge note: this conflicts with #68 (app/pip/page.tsx, components/pip/pip-feature.tsx modify/delete, plus app/routes.tsx and tests/browser/browser_test.py). I'd suggest landing this first and rebasing #68.
|
Addressed points 1–5 in fdf4e70: updated site-verification guidance, removed the five orphaned screenshots and QR ignore rule, cleaned up CSS whitespace, and added an avatar image-error skeleton regression test. I left |
* Remove Orchid and Keiki references Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Remove unused Orchid artwork * Drop Orchid previews and leave Pip files to #69 --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Changes
/pipand/pip.htmlto the existing 404, retain shared image-loading coverage, and verify exported internal links.Verification
npm run lintnpm run test:pondnpm run test:e2e(34 tests, including internal-link integrity)