fix: replace bare except clauses with except Exception across codebase#562
Closed
Kailigithub wants to merge 1 commit into
Closed
fix: replace bare except clauses with except Exception across codebase#562Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all 46 bare
except:clauses withexcept Exception:across 15 files.Bare
except:catches all exceptions includingKeyboardInterruptandSystemExit, silently swallowing critical signals that should propagate. Usingexcept Exception:is the standard Python best practice — it catches runtime errors while allowing system-level exceptions to pass through.Files Changed
Verification
py_compilesyntax checkruff check --select E722reports 0 remaining bare except clausesexcept:→except Exception:), no logic altered