Update SPI Device HAL to use new autogen interface#387
Open
ziuziakowska wants to merge 1 commit into
Open
Conversation
ziuziakowska
force-pushed
the
hal-autogen-rework-spi-device
branch
from
1755b42 to
2cfbaa7
Compare
ziuziakowska
force-pushed
the
hal-autogen-rework-spi-device
branch
2 times, most recently
from
f45de2f to
8b85c97
Compare
ziuziakowska
changed the title
Signed-off-by: Alice Ziuziakowska <a.ziuziakowska@lowrisc.org>
ziuziakowska
force-pushed
the
hal-autogen-rework-spi-device
branch
from
8b85c97 to
98fbdda
Compare
engdoreis
reviewed
May 14, 2026
Collaborator
engdoreis
left a comment
engdoreis
left a comment
There was a problem hiding this comment.
Thanks for the changes, I had a quick look and letf some comments.
I'm happy to give a more detailed review when it pass CI.
| return true; | ||
| default: | ||
| uprintf(ctx->console, "\nUnsupported command: 0x%0x", cmd.opcode); | ||
| uprintf(ctx->console, "Unsupported command: 0x%x\n", cmd.opcode); |
Collaborator
There was a problem hiding this comment.
Why remove the line break?
| #include <stdint.h> | ||
|
|
||
| bool spi_device_interrupt_is_pending(spi_device_t spi_device, uint8_t intr_id) | ||
| enum : size_t { |
Collaborator
There was a problem hiding this comment.
These structs should not be inside the spi hal, you should create a flash header somewhere, then the app should call the hal to configure the spi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #299.