Skip to content

test(replan): align machine cadence default expectation - #6001

Closed
mikamikasuki wants to merge 1 commit into
loopx-project:mainfrom
mikamikasuki:codex/fix-replan-machine-catalog-test
Closed

mikamikasuki wants to merge 1 commit into
loopx-project:mainfrom
mikamikasuki:codex/fix-replan-machine-catalog-test

Conversation

@mikamikasuki

Copy link
Copy Markdown
Contributor

Goal and Delivered Outcome

The machine-configuration API test expected completed_todos for the todo_replan_cadence_machine_defaults_v1 template. On canonical main, the namespace’s documented product default is five effective_turns, so the assertion fails even though the configuration source and documentation agree.

This changes the fixture expectation to effective_turns, keeping the API contract regression aligned with the current default.

  • Outcome basis: current product default and machine configuration contract.
  • Observable before → after: the inspection test fails on canonical main due to the stale completed_todos expectation; it passes when asserting the documented effective_turns default.
  • Issue/task and intended base: self-contained test maintenance; base main at 3ed5d6bc88ffaaa05f2b1bc6a98ed5d921379fd1.

Author Declaration

  • Written by: model_agent — OpenAI GPT-6 Luna Medium.

Implemented against

  • Specification and revision: docs/quota-allocation.md and loopx/capabilities/todo_replan_cadence/machine_defaults.py at 3ed5d6bc88ffaaa05f2b1bc6a98ed5d921379fd1.
Criterion Disposition Symbol / path Test or command
The v1 machine default reports five effective Turns implemented tests/test_chat_machine_configuration_api.py test_inspection_lists_registered_namespaces_without_local_refs
  • Self-check before submission: reproduced the stale assertion failure on exact main, checked the machine-default implementation and its documented contract, and confirmed the diff changes only that expectation.

Scope And Continuation

  • Completed scope: aligned the machine-configuration inspection test with the current default; no runtime behavior changed.
  • Slice boundary / successor: complete within this scope.

Validation

  • Tested revision: 899fe83ed7883106c45af4b6649072d530decfd9 (base 3ed5d6bc88ffaaa05f2b1bc6a98ed5d921379fd1)
  • Run state: finished
  • Input classes: synthetic
Check kind Result Public-safe evidence / limitation
regression_parity passed The affected assertion fails on exact main because actual count_unit is effective_turns while expected is completed_todos; the updated focused test passes on this head.
unit passed tests/test_chat_machine_configuration_api.py: 14 passed.
static passed Ruff for the changed test and git diff --check passed.
  • Coverage and gaps: the changed surface is a single API-template expectation. The full repository suite was not run.

Frontend / Visual Evidence

  • UI impact: none
  • Before: N/A
  • After: N/A
  • States and viewports shown: N/A
  • Source data: synthetic
  • Attention review: not applicable; no user interface changed.

Type of Change

  • Test update

LoopX Area

  • Control plane (goals, todos, quota, scheduler, registry, runtime)

Technical Direction

  • N/A; this updates a test expectation to the current product default.

Shared-authority RFC fixture impact

  • N/A; no authority schema or runtime contract changed.

Boundary Checklist

  • No private state, credentials, raw traces, internal links or local paths are included.
  • No maintainer-owned benchmark work is duplicated.
  • Scope is limited to the machine-configuration default assertion.
  • UI impact is marked none.
  • The commit includes a DCO Signed-off-by trailer.

Signed-off-by: mika <211269698+mikamikasuki@users.noreply.github.com>
@mikamikasuki

Copy link
Copy Markdown
Contributor Author

Closing in favor of #5980, which already includes this exact effective_turns expectation change and the related exact-Todo fixture correction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant