Repository navigation
test(replan): align machine cadence default expectation - #6001
Closed
mikamikasuki wants to merge 1 commit into
Closed
mikamikasuki wants to merge 1 commit into
mikamikasuki wants to merge 1 commit into
Conversation
Signed-off-by: mika <211269698+mikamikasuki@users.noreply.github.com>
mikamikasuki
requested review from
huangruiteng and
loopx-agent
as code owners
October 9, 2026 01:06
Contributor
Author
|
Closing in favor of #5980, which already includes this exact |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal and Delivered Outcome
The machine-configuration API test expected
completed_todosfor thetodo_replan_cadence_machine_defaults_v1template. On canonical main, the namespace’s documented product default is fiveeffective_turns, so the assertion fails even though the configuration source and documentation agree.This changes the fixture expectation to
effective_turns, keeping the API contract regression aligned with the current default.completed_todosexpectation; it passes when asserting the documentedeffective_turnsdefault.mainat3ed5d6bc88ffaaa05f2b1bc6a98ed5d921379fd1.Author Declaration
Implemented against
docs/quota-allocation.mdandloopx/capabilities/todo_replan_cadence/machine_defaults.pyat3ed5d6bc88ffaaa05f2b1bc6a98ed5d921379fd1.tests/test_chat_machine_configuration_api.pytest_inspection_lists_registered_namespaces_without_local_refsScope And Continuation
Validation
899fe83ed7883106c45af4b6649072d530decfd9(base3ed5d6bc88ffaaa05f2b1bc6a98ed5d921379fd1)count_unitiseffective_turnswhile expected iscompleted_todos; the updated focused test passes on this head.tests/test_chat_machine_configuration_api.py: 14 passed.git diff --checkpassed.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
Boundary Checklist
Signed-off-bytrailer.