Repository navigation
test(replan): align successor fixtures with current contracts - #5994
huangruiteng merged 1 commit into
Conversation
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent; gpt-6.1-sol; OpenAI; runtime_reported; reasoning_effort=xhigh.
Exact head: 809a180; base: 3ed5d6b.
动机
维护者验证重规划后续任务时,旧夹具会误报失败,无法可靠判断后续任务是否持久生效。
旧测试未指定周期单位,又把读取时计算的版本 metadata 当成持久 Todo 字段;本 PR 明确周期并隔离只读 metadata,使既有恢复检查能够完成。
独立基础版本复现两处失败,head 的真实 CLI、File/SQLite 后续任务、重复写回和再次触发检查均通过。
本 PR 不改变产品默认周期、任务准入、存储协议、权限、运行时代码或用户操作步骤。
改动思路
Existing TypeScript quota/replan and coordination_state_contract owners; Python adapts source IO. No new decision owner.
保持产品 owner 和原断言,只修正独立复现的夹具输入。维持旧误报没有价值;修改运行时或删除完整断言会扩大范围并丢失回归信号。
具体改动
test_cli_successor_refresh_resets_periodic_window 显式使用 replan_after_completed_todos=1,与旧周期 fallback 的测试目的相符;todoFixtureRecord 删除 content_revision 后仍交给 canonicalTodoDomainRecord 严格校验。两文件共 +4/-0,没有新增测试、协议或抽象。
规范:docs/quota-allocation.md,revision 3ed5d6b;Goal Review Cadence implemented;Explicit completed-Todo cadence implemented。既有 required-work-context、quota cadence 和 typed domain/source owner 一起核对,没有把作者声明当验收依据。
扫描既有 tests/examples、完整队列及同作者近期 PR:相关维护触及不同失败边界,这两项修正原测试,没有新增同形示例或低价值 scaffold。
对主干的风险
完整模块 B 为 10 passed / 2 failed,H 为 12 passed。实际 Node fixture/domain 对照验证 native/legacy 普通字段相同、输入未变、非法字段仍拒绝;共享迁移与验收消费者 57 passed / 0 failed / 15 PostgreSQL skipped。typecheck、Ruff、diff check 通过。初次私有 probe 漏掉必需的 done/archive_state,被正确拒绝;补全合成输入后的独立对照通过,原失败保留。
未验证真实 PostgreSQL、全仓、安装态 UI 或 live host;15 个 PG 跳过不算通过。本改动不更改 provider 或产品状态规则。对共享 fixture 的严格字段反例和 File/SQLite 消费者已覆盖当前风险。
未查询、轮询或等待 CI;评审以独立的基础版本和当前版本验证为依据。
未来重构检查:metadata 适配保留在现有 fixture,复用现有 domain owner;无需另建通用过滤器,避免把非法字段全部吞掉。
我的整体评价
APPROVE,无阻塞发现。该结论仅覆盖这次精确版本的完整测试维护改动,恢复了可用回归检查;不宣告产品 Goal 完成、模型采纳、安装升级或其它 provider 已验收。当前规范依据与完整正反路径相符。
English verdict: APPROVE — 809a180; current fixture boundary restored and independently qualified against 3ed5d6b; retained exact assertions and negative sensitivity pass; no blocking findings.
Signed-off-by: mika <211269698+mikamikasuki@users.noreply.github.com>
809a180 to
94912c6
Compare
Goal And Delivered Outcome
content_revision. After rebasing onto current upstream main 0e5acf, the updated Python module passes 12/12 and the TypeScript fixture consumer passes 41 tests (15 PostgreSQL cases skipped because no local server is configured). The four selectors that failed in older hosted run 37849055877 fail identically on exact main 0e5acf and exact head 94912c6; this fixture-only patch does not introduce those failures.Author Declaration
Implemented against
docs/quota-allocation.mdand the Todo domain/read-model boundary inloopx/control_plane/coordination/local_authority_shadow_projection.pyat 0e5acfe. Both reference files are unchanged between the original base and this revision.Scope And Continuation
Validation
tests/control_plane/test_replan_successor_durable_ack.py: 12 passed, including the real CLI path and canonical Node fixture.goal_acceptance_authority.test.ts: 56 total, 41 passed, 15 PostgreSQL cases skipped (no local PostgreSQL server configured).npm run typecheck:control-plane, andgit diff --checkpassed.Frontend / Visual Evidence
Type of Change
LoopX Area
Technical Direction
Shared-authority RFC fixture impact
Boundary Checklist