Skip to content

fix(acceptance): reconcile Goal recreation lifecycle - #5972

Open
Duang777 wants to merge 12 commits into
loopx-project:codex/fix-acceptance-goal-instance-fencefrom
Duang777:codex/fix-acceptance-source-recreation
Open

Duang777 wants to merge 12 commits into
loopx-project:codex/fix-acceptance-goal-instance-fencefrom
Duang777:codex/fix-acceptance-source-recreation

Conversation

@Duang777

@Duang777 Duang777 commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • route Python acceptance operations with the exact registered goal_ref
  • bind and retire acceptance before draining source-owned effects, then publish the successor under the source and canonical writer locks
  • reconcile the new acceptance lifecycle after source publication while retaining the source lifetime lock
  • recover legacy pre-lifecycle state and interrupted publication without letting stale A-to-B replay alter a later successor

This is stacked on #5970 and completes its source-session recreation integration for #5206. After #5970 merges, retarget this PR to main.

Validation

  • PYTHONPATH="$PWD" ../loopx/.venv/bin/python -m pytest -q tests/control_plane/test_goal_acceptance_source_recreation.py (10 passed)
  • source recreation regression set (37 passed)
  • broader Python acceptance set (78 passed)
  • node --no-warnings --experimental-sqlite --experimental-strip-types --test tests/control_plane_ts/goal_acceptance_authority.test.ts (49 passed, 19 PostgreSQL/environment skips)
  • npm run typecheck:control-plane
  • standard premerge gate (13/13 selected checks passed)
  • full TypeScript control-plane suite: 4,249 passed, 35 skipped; the sole failure is the existing content_digest_single_owner finding in unchanged action_review_plan.ts:114, reproduced on the fix(acceptance): fence authority by Goal instance #5970 base

Runtime boundary

  • File and SQLite exact-routing, recreation, crash-replay, and historical-migration paths pass locally.
  • PostgreSQL parity rows are present but require LOOPX_TEST_POSTGRES_URL; no local PostgreSQL test URL was configured.
  • No provider promotion or self-merge is performed.

Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
@Duang777
Duang777 requested a review from steven-kid as a code owner October 9, 2026 05:20
Signed-off-by: Duang777 <duangjl007@gmail.com>
@Duang777
Duang777 requested a review from maxliux5 as a code owner October 9, 2026 06:12
@mergify

mergify Bot commented Oct 9, 2026

Copy link
Copy Markdown

Hi @Duang777, the DCO Sign-off check did not pass. Please inspect
its details first: checkout, fetch, timeout or infrastructure errors
need their own recovery, not a rewrite of otherwise signed commits.

If the log confirms a missing Signed-off-by trailer, amend the
affected commit with git commit --amend -s; for multiple commits,
use an interactive rebase against the current base from the correct
base-repository remote and sign off each affected commit. Push the
rewritten PR branch with git push --force-with-lease origin HEAD.

Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>
Signed-off-by: Duang777 <duangjl007@gmail.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant