Skip to content

Release audio session after alarm so other audio is no longer ducked #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bjorkert wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Release audio session after alarm so other audio is no longer ducked #806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions LoopFollow/Controllers/AlarmSound.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,27 @@ class AlarmSound {
audioPlayer = nil

restoreSystemOutputVolume()
releaseAudioSession()
}

/// Hands the audio session back once LoopFollow has nothing left to play, so
/// audio from other apps that was ducked or interrupted returns to full volume.
/// While Silent Tune's loop holds the session, it stays active with the
/// mixable category that loop uses.
static func releaseAudioSession() {
guard !isPlaying else { return }

let session = AVAudioSession.sharedInstance()
do {
if MainViewController.shared?.backgroundTask.isPlaying == true {
try session.setCategory(.playback, mode: .default, options: .mixWithOthers)
} else {
try session.setActive(false, options: .notifyOthersOnDeactivation)
}
} catch {
let nsError = error as NSError
LogManager.shared.log(category: .alarm, message: "AlarmSound - audio session release failed [code \(nsError.code)]: \(error.localizedDescription)")
}
}

static func playTest() {
Expand Down Expand Up @@ -318,6 +339,7 @@ class AudioPlayerDelegate: NSObject, AVAudioPlayerDelegate {
AlarmSound.playNextWithDelay()
} else {
Observable.shared.alarmSoundPlaying.value = false
AlarmSound.releaseAudioSession()
}
}

Expand Down
14 changes: 1 addition & 13 deletions LoopFollow/ViewControllers/MainViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1266,18 +1266,6 @@ class MainViewController: UIViewController, UNUserNotificationCenterDelegate {

extension MainViewController: AVSpeechSynthesizerDelegate {
func speechSynthesizer(_: AVSpeechSynthesizer, didFinish _: AVSpeechUtterance) {
let appState = UIApplication.shared.applicationState
let isSilentTuneMode = Storage.shared.backgroundRefreshType.value == .silentTune

if isSilentTuneMode, appState == .background {
LogManager.shared.log(category: .general, message: "Silent tune active in background; not deactivating session.", isDebug: true)
} else {
do {
try AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation)
LogManager.shared.log(category: .general, message: "Audio session deactivated after speech.", isDebug: true)
} catch {
LogManager.shared.log(category: .alarm, message: "Failed to deactivate audio session: \(error)")
}
}
AlarmSound.releaseAudioSession()
}
}