Repository navigation
Conversation
…iagnose Extend the diagnose InstanceManagers check to verify the critical labels controllers use to discover instance managers, using the same types.GetInstanceManagerLabels() the controllers build their selectors from. Missing or unexpected labels are reported as errors. Related: longhorn/longhorn#9458 Signed-off-by: Sudeep Reddy <148759887+sudeepr34@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the diagnose InstanceManagers check to verify the critical labels controllers use to discover instance managers, using the same types.GetInstanceManagerLabels() the controllers build their selectors from. Missing or unexpected labels are reported as errors.
Related: longhorn/longhorn#9458
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9458
Issue # longhorn/longhorn#9458
What this PR does / why we need it:
Extends the
longhornctl diagnoseInstanceManagers check to verify that each InstanceManager carries the labels the Longhorn controllers use to discover it, computed with the sametypes.GetInstanceManagerLabels()the controllers build their list selectors from (datastore.ListInstanceManagersBySelectorRO). A missing label or unexpected value is reported as an error, since a controller that can't find a valid instance manager can't attach or detach volumes.Special notes for your reviewer:
go build ./...,go vet, andgofmtare clean.go test ./pkg/remote/diagnose/...passes, including the newTestCheckInstanceManagerLabels(labels present / missing / mismatched cases). The existingTestEvaluateInstanceManagersfixture was updated to build well-formed IMs so it keeps covering the running-state logic.Additional documentation or context