shell: update QuickJS JIT to 0.12.11 - #3338
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
quickjs-jit,quickjs-jit-runtime, and the localrquickjs-compatfacade from 0.12.9 to the v0.12.11 release commit (96593cd).quickjs-jit-stdlibon its existing compatibility revision, as in the 0.12.9 update (shell: update QuickJS JIT to 0.12.9 #3116); it is not part of the release tag.0.12.10 is skipped deliberately: it regressed gpui-shell renders. 0.12.11 (longbridge/quickjs-jit#33) fixes that regression.
Performance
tests::benchmark::emit_one_jit_acceptance_sample, i7-13700KF, release build. Each fresh process renders 64 warmup frames, then the mean of 200 measured renders is reported in µs. Ten retained process pairs per configuration, alternating order. "1 core" pins the render thread and the JIT worker to one CPU; "2 cores" uses two physical cores. Measured on the quickjs-jit runtime code that shipped as 0.12.11 (8fa2a48; later commits only change tests and sanitizer builds).Checksums agree in every process; there are no native fallbacks or deopts. The raw data is in quickjs-jit
benchmarks/results/shell-tiering-8fa2a48-gpui-shell-x86_64.json.How to Test
cargo fmt -p gpui-shell -- --checkcargo check -p gpui-shell --all-targetscargo test -p gpui-shell --release(714 + 8 passed)git diff --checkChecklist
cargo runfor story tests related to the changes.🤖 Generated with Claude Code