chore: upgrade notify to 8.2 and harden theme watching - #3320
Merged
Merged
Conversation
Restore mutation event filtering so reading JSON themes cannot trigger another reload, and watched-directory renames still invalidate the registry. Keep nonblocking coalescing, notify 8.2, and rescan handling; add focused regression tests. Assisted-by: OpenAI Codex
Keep the original watcher callback structure and limit the correction to its event predicate. Remove the helper and in-file tests; verify the exact inline predicate with the isolated notify integration harness. Assisted-by: OpenAI Codex
huacnlee
enabled auto-merge (squash)
September 30, 2026 03:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
notifyfrom 7.0 to 8.2 and improves theme directory watchingTheme changes are now coalesced without blocking the notify thread, reloads handle
need_rescan()andEventKind::Any, watcher errors are logged, and the watcher now matches the non-recursive theme loaderChecklist
cargo runfor story tests related to the changes.