Repository navigation
overlay: one declaration per placement for three data labels - #184
Merged
Merged
Conversation
D_L14_00161FBC and D_L14_00161FC0 in 002fded0.c were declared twice, once without and once with sda; keep one sda declaration each. D_0015EE18_gp_gp is the label D_0015EE18_gp itself.
Decompilation progress
No function changed its match state compared with main (ae03241). Compared with main (ae03241). C_FUZZY uses main's last measurement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After #182,
src/overlays/l14/gameplay/entities/002fded0.cdeclaredD_L14_00161FBCunder the same name twice, once plain and once withsda.D_L14_00161FC0also had two declarations: an_gpalias and a plain-namedsdaone.001ff938.cand00203b18.cusedD_0015EE18_gp_gpfor the labelD_0015EE18_gp.After
002fded0.c: onesdadeclaration each forD_L14_00161FBCandD_L14_00161FC0, at the top. The*(float *)&casts around them are gone.001ff938.c,00203b18.c:D_0015EE18_gp_gpisD_0015EE18_gp.3 files, declarations and names only.
Verification
make elf: not run (no change to the boot ELF sources)make overlaysroute (ninja c/<file>.c.o). Its.text, data and relocations (offset, type, symbol) matchmain.00203b18.calso compiles with-DNON_MATCHING.scripts/test_public_tools.pypasses (99 tests OK);data-decls.pystill reports 613