Repository navigation
fix: place select_world_object_resource_tables data after its promotion - #178
Merged
Merged
Conversation
The unit moved out of assembly/, but its DATA_OVERLAYS key kept the old path, so its .data (class_material_maps, 0x480 B) was discarded at link time and the retail blob supplied those bytes. Rename the key so the section is placed at 0x1CBBE0 again, and drop the duplicate includes left from the old #else body.
Decompilation progress
No function changed its match state compared with main (ce39091). Compared with main (ce39091). C_FUZZY uses main's last measurement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
textbin/world/data/select_world_object_resource_tablesmoved out ofassembly/(#177), but itsDATA_OVERLAYSkey inconfigure.pykept the oldassembly/...path. Keys are matched withendswith, so the unit's.data(0x480 B,class_material_maps) landed in the linker's discarded sections and the retail blob supplied those bytes.make elfstill passed, so nothing flagged it.After
textbin/world/data/select_world_object_resource_tables, so the section is placed at 0x1CBBE0 again (checked in the link map).#includelines left over from the old#elsebody are removed.Verification
make elfends withPASS: reconstructed boot ELF matches retailmake overlaysends withPASS(overlay changes): n/a, no overlay changesmake checkpasses