Repository navigation
Batch 15: promote cmd_sem_init and seven overlay functions - #175
Merged
mateuszklysz merged 251 commits intoOct 14, 2026
Merged
Conversation
Report for SCUS_971.99 (59fa049 - 453f2a1)📈 Matched code: 87.14% (+0.24%, +8468 bytes) ✅ 8 new matches
|
Decompilation progress
8 newly matched functions (8,468 B)
Compared with main (59fa049). C_FUZZY uses main's last measurement. |
pezzadev
marked this pull request as ready for review
October 14, 2026 00:01
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
The batch begins at upstream main
59fa04961077fffa23445e9ca9ba83bbe0d342b0. The eight units below were assembly-backed, and several overlay functions had only retail stubs or unfinished C bodies.After
Promote eight exact C units, totalling 8,468 bytes of unique function code:
sdk/library/cmd_sem_initFUN_L06_002fbfb0FUN_L08_002dc9a8FUN_L10_002e8ab0FUN_L18_002f9eb8FUN_L01_002b91c8FUN_L00_002cbcc0FUN_L00_00262030Move
cmd_sem_initto its SDK owner and update the linker configuration. The overlay promotions retain their existing catalogue ownership.Add guarded C bodies for 17 overlay functions covering entity state machines, path following, collision handling and effects. Refine existing pending resident and overlay bodies, including SIF command initialization, music transitions, text rendering and graphics setup. These bodies retain their retail oracles and remain pending; successful full-image validation does not establish that their C matches.
Reuse the shared
CollisionHit,SwarmPathandVoicePoolWindowlayouts. Preserve the establishedair_accelandregister_part_typesnames with canonical assembly labels, and retainFUN_001f7978as the canonical draw-frame callee.Verification
make elfends withPASS: reconstructed boot ELF matches retail; the reconstructed executable also matches the pinned retail SHA-256.make overlaysends withPASS.make checkpasses.