Skip to content

[CI] Wait for the flush in testBatchSizeFromConfig instead of sleeping 4 s #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PetrHeinz merged 1 commit into from
Sep 29, 2026
Merged

[CI] Wait for the flush in testBatchSizeFromConfig instead of sleeping 4 s #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/test/java/com/logtail/logback/LogtailAppenderBatchConfigSizeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,13 @@ public void testBatchSizeFromConfig() throws Exception {
MDC.put("requestId", "testErrorLog");
MDC.put("requestTime", 199 + "");
this.logger.info(batchRunId + " Custom batch size Final Batch Groot ");
Thread.sleep(4000);
assertEquals(1, this.appender.apiCalls);

// The 200th line sends the batch on another thread. Wait for that flush instead of a fixed time: a request to
// the real endpoint now and then takes several seconds, or fails and is retried by the appender
this.appender.awaitFlushCompletion();

isOk();
assertEquals(1, this.appender.acceptedCalls);
}

private void isOk() {
Expand Down
5 changes: 5 additions & 0 deletions src/test/java/com/logtail/logback/LogtailAppenderDecorator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,17 @@ public class LogtailAppenderDecorator extends LogtailAppender {
private Exception exception;
private LogtailResponse response;
protected int apiCalls = 0;
// Calls answered with 202, i.e. apiCalls without the failed ones the appender retried
protected int acceptedCalls = 0;

@Override
protected LogtailResponse callHttpURLConnection(int flushedSize) throws IOException {
try {
apiCalls++;
this.response = super.callHttpURLConnection(flushedSize);
if (isOK()) {
acceptedCalls++;
}

return this.response;
} catch (Exception e) {
Expand Down
Loading