chore: wind down hosted infrastructure and deployerphp.com references - #395
Conversation
The deployerphp.com domain is being retired. Point readers at the docs folder and the loadinglucian/deployerphp.com repo for a local docs site.
The AWS, DigitalOcean, and Cloudflare test accounts and domains have been spun down; these tests cannot run without live credentials.
Removes the hourly janitor schedule and comments out the cloud-tests and janitor jobs that depend on retired cloud provider accounts.
📝 WalkthroughWalkthroughThe change disables scheduled cloud CI jobs and AWS and DigitalOcean integration suites. It also updates README branding links and adds navigation to repository and website documentation. ChangesCloud CI and integration tests
Repository documentation
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 88: Update the README documentation link in the sentence about full
documentation to use a clone-safe relative target such as docs or ./docs instead
of the root-relative /docs path.
In `@tests/bats/cloud-do.bats`:
- Around line 3-6: Update the provider list in the disabled-test NOTE to mention
only DigitalOcean, removing AWS and Cloudflare references while preserving the
existing guidance about credentials and re-enabling the suite.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cca9fa8b-ed38-4b50-a707-022b3b7e22ab
📒 Files selected for processing (4)
.github/workflows/ci.ymlREADME.mdtests/bats/cloud-aws.batstests/bats/cloud-do.bats
|
|
||
| ## Documentation | ||
|
|
||
| The full documentation lives in the [docs](/docs) folder of this repository. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf 'README link context:\n'
if [ -f README.md ]; then
nl -ba README.md | sed -n '80,94p'
else
printf 'README.md not found\n'
fi
printf '\nGit tree entries for docs:\n'
git ls-files | grep -E '(^|/)docs(/|$)' | sed -n '1,40p' || trueRepository: loadinglucian/deployer-php
Length of output: 225
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python3 - <<'PY'
import os, subprocess, pathlib, re
path = pathlib.Path("README.md")
print("README exists:", path.is_file(), path.stat().st_size if path.is_file() else None)
if path.is_file():
lines = path.read_text(encoding="utf-8").splitlines()
for i in range(82, 92):
if 2 <= i <= len(lines):
print(f"{i}: {lines[i-1]}")
matches = re.findall(r'\[([^\]]*)\]\(([^\)]*)\)', path.read_text(encoding="utf-8"))
print("markdown links containing docs:")
for text, href in matches:
if "docs" in href.lower():
print(f"{text}: {href}")
cmd = ["git", "ls-files"]
out = subprocess.check_output(cmd, encoding="utf-8")
docs_lines = [line for line in out.splitlines() if line.startswith("docs") or re.search(r'(^|/)docs($|/)', line)]
print("tracked docs entries:", len(docs_lines))
for line in docs_lines[:50]:
print(line)
PYRepository: loadinglucian/deployer-php
Length of output: 1159
Use a clone-safe relative link for docs.
GitHub resolves /docs from the repository root, but this may not work when the README is opened from a local clone. Use [docs](docs) or [docs](./docs) instead.
Proposed fix
-The full documentation lives in the [docs](/docs) folder of this repository.
+The full documentation lives in the [docs](docs) folder of this repository.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| The full documentation lives in the [docs](/docs) folder of this repository. | |
| The full documentation lives in the [docs](docs) folder of this repository. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 88, Update the README documentation link in the sentence
about full documentation to use a clone-safe relative target such as docs or
./docs instead of the root-relative /docs path.
Source: MCP tools
| # NOTE: These tests are disabled because the cloud provider accounts | ||
| # (AWS, DigitalOcean, Cloudflare) and test domains they depend on have | ||
| # been spun down. Uncomment the lines below to re-enable them once | ||
| # active credentials are available again. |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the provider list in the NOTE.
This header is copied from tests/bats/cloud-aws.bats. It names AWS and Cloudflare, but this suite depends only on DigitalOcean. setup_file calls require_do_credentials and do_cleanup_all, and no test calls a cf: command. A reader who restores this suite may search for Cloudflare credentials that the file never uses.
📝 Proposed fix for the provider list
-# NOTE: These tests are disabled because the cloud provider accounts
-# (AWS, DigitalOcean, Cloudflare) and test domains they depend on have
-# been spun down. Uncomment the lines below to re-enable them once
-# active credentials are available again.
+# NOTE: These tests are disabled because the DigitalOcean account and
+# the test domain they depend on have been spun down. Uncomment the
+# lines below to re-enable them once active credentials are available
+# again.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # NOTE: These tests are disabled because the cloud provider accounts | |
| # (AWS, DigitalOcean, Cloudflare) and test domains they depend on have | |
| # been spun down. Uncomment the lines below to re-enable them once | |
| # active credentials are available again. | |
| # NOTE: These tests are disabled because the DigitalOcean account and | |
| # the test domain they depend on have been spun down. Uncomment the | |
| # lines below to re-enable them once active credentials are available | |
| # again. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@tests/bats/cloud-do.bats` around lines 3 - 6, Update the provider list in the
disabled-test NOTE to mention only DigitalOcean, removing AWS and Cloudflare
references while preserving the existing guidance about credentials and
re-enabling the suite.
1 participant
Summary
cloud-aws.batsandcloud-do.batstest suites, which require the now-retired AWS, DigitalOcean, and Cloudflare accounts and test domains (vm.batsis untouched — it runs entirely against local Lima VMs)cloud-tests-do,cloud-tests-aws,janitor-targeted, andjanitor-sweepCI jobs; quality checks and local VM tests continue to runAll disabled tests and jobs are commented out rather than deleted so they can be restored if live credentials return.
Notes
DOTENV_FILEandSSH_PRIVATE_KEY_B64repo secrets can be reviewed/deleted after merge