fix: return err instead of nil on saveSnapshot failure#409
Open
Qian-Cheng-nju wants to merge 3 commits intolni:masterfrom
Open
fix: return err instead of nil on saveSnapshot failure#409Qian-Cheng-nju wants to merge 3 commits intolni:masterfrom
Qian-Cheng-nju wants to merge 3 commits intolni:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
saveRaftStateandsaveSnapshotsininternal/logdb/db.gohavereturn nilwherereturn errwas intended:When
saveSnapshotfails (e.g. disk I/O error inlistSnapshots),return nilcauses the function to exit early without callingsaveEntriesorCommitWriteBatch, silently dropping the entire batch of raft log entries. The caller receives a nil error and assumes the write succeeded.The same commit (0d704a2) has a third call site in
importSnapshotthat correctly writesreturn err.