Repository navigation
feat: use onchain wallet from lnbits core (v1.7.0) - #94
Open
talvasconcelos wants to merge 7 commits into
Open
talvasconcelos wants to merge 7 commits into
talvasconcelos wants to merge 7 commits into
Conversation
talvasconcelos
changed the title
Add the `core:<wallet-id>` reference alongside existing watchonly IDs. Core wallets are listed before watchonly wallets, filtered to the configured network, and validated server-side for ownership, readiness, hot-wallet backup, and network. Generate fresh addresses through the core onchain address endpoint using the selected wallet's invoice key. Bare watchonly IDs and the existing watchonly address path remain unchanged. Add setup, backup, and create-wallet UI actions, and reject a mismatched standard mempool.space URL before creating a payable checkout. Track the charge only after it is persisted.
Mempool address tracking is a live delta subscription. It does not replay state, the client must send `init`, and reconnect loses the subscriptions. SatsPay also treated the delta payload as the full balance, so confirmed and partial payments were unreliable. Send `init`, resubscribe tracked addresses after every connect, and use websocket events only as triggers for an authoritative HTTP balance refresh. Add one poll task per open charge as the missed-event fallback. It stops when the charge is paid, expired, deleted, or missing, and all tasks are cancelled when the extension stops. The previous global poll task is removed.
talvasconcelos
force-pushed
the
feat/allow_onchain_wallet
branch
from
November 2, 2026 14:54
140881b to
c899eeb
Compare
talvasconcelos
marked this pull request as ready for review
November 2, 2026 14:57
talvasconcelos
requested review from
a team,
DoktorShift,
arcbtc,
blackcoffeexbt,
motorina0 and
prusnak
and removed request for
a team,
DoktorShift and
prusnak
November 2, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use onchain wallet feature