Repository navigation
fix: classify TunnelMeOut as an admin extension in JMeter - #925
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
001_extensions-enable-all.jmxvisits enabled extensions as a regular user. TunnelMeOut restricts its page to the superuser and correctly returns HTTP 403, but the test expected HTTP 200 because TunnelMeOut was missing fromadminExtensions.Add
tunnel_me_outto the existing list alongsidenostrclient, so the existing admin-extension assertion handles it.Validation:
git diff --checkpassed.001run passed installation, enable/disable, and uninstallation for all 57 extensions. Both enabled-page checks for TunnelMeOut returned HTTP 403 and passed the existing admin assertion.Release not found). A second run hit the same manifest-fetch failure while installing Nostr Bunker. Neither run completed successfully; these failures were separate from the TunnelMeOut assertion.