Skip to content

fix: verify LNURL webhooks at the receiver - #921

Closed
motorina0 wants to merge 1 commit into
combine/alanbits-extension-releasesfrom
fix/jmeter-lnurl-webhooks
Closed

motorina0 wants to merge 1 commit into
combine/alanbits-extension-releasesfrom
fix/jmeter-lnurl-webhooks

Conversation

@motorina0

Copy link
Copy Markdown
Collaborator

002_lnurl.jmx expects LNURLp to expose the webhook receiver's echoed response in payment metadata. LNURLp now redacts that response and reports Webhook delivered., so the plan fails despite successful delivery.

Capture LNURLp requests in a local receiver managed by the existing plan, preserving the payment-hash, custom-header and body assertions. Assert successful delivery and response redaction, poll asynchronous webhook metadata for up to 30 seconds, enable private webhook destinations in the local test setup, and use the configured server URL in the withdraw page check. The existing withdrawal webhook assertions are retained.

Validation against fix_pydantic2_changes at 57b88dfdc, FakeWallet, and the requested release manifest:

  • Independently captured a real webhook first: payment hash, header, body, amount, comment and link matched; delivery metadata was correct.
  • Full 002 suite passed twice, including a run with the standard JMeter mirror: six pay-link and six withdrawal flows, zero failures.
  • Assertion controls accepted a valid request and rejected eight malformed/missing request or metadata cases.
  • Polling controls verified delayed completion, failed delivery and HTTP errors; XML parsing, JS formatting and diff checks passed.

No new payment scenarios or dependencies are added. The previously passing mandatory 001 suite was not rerun for this test-only follow-up.

@motorina0 motorina0 closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant