Fix add_text/regenerate return tuple size mismatch in single-model server#3851
Open
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Open
Fix add_text/regenerate return tuple size mismatch in single-model server#3851Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Chessing234 wants to merge 1 commit intolm-sys:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes #3783.
In
fastchat/serve/gradio_web_server.py,add_textandregeneratehave early-return paths that yield a 9-tuple while the normal path returns an 8-tuple. All three callers (textbox.submit,send_btn.click,regenerate_btn.click) wire the output to[state, chatbot, textbox] + btn_list— 8 outputs. The 9-value returns trigger a Gradio output-count mismatch error, so any empty-input submit, conversation-limit hit, or regenerate-without-regen-support crashes the UI.Root cause
Commit be5db52 (Merge operation & multimodal arena, #3425) removed the
imageparameter fromadd_textin the single-model server and dropped the trailingNonefrom the normal return path, but left the sameNonein the two early-return paths ofadd_textand the early-return path ofregenerate. The extraNonewas the image slot that no longer exists.Fix
Drop the leftover
Nonefrom the three early returns so every path returns the 8 values the output components expect. No other behavior changes.