Tupek/solid axisym - #1638
Conversation
| TEST(SolidMechanics, AxisymmetricPressureInnerResultant) | ||
| { | ||
| axom::sidre::DataStore datastore; | ||
| StateManager::initialize(datastore, "axisymmetric_pressure_inner_resultant"); |
There was a problem hiding this comment.
Would it be helpful to have a helper macro that gives you the test name?
Something like:
#define GTEST_FULL_NAME() \
([]() -> std::string { \
const auto* info = \
::testing::UnitTest::GetInstance()->current_test_info(); \
return info \
? std::string(info->test_suite_name()) + "_" + info->name() \
: std::string{}; \
}())
It would return SolidMechanics_AxisymmetricPressureInnerResultant in this case.
I could do this outside of this PR if you think its useful.
There was a problem hiding this comment.
I'd say no need. I happens that a convenient/lazy name here is sometimes the test name, or similar.
There was a problem hiding this comment.
we have been bit by this problem in the past
|
I see you've changed the convention by putting the 2*pi factor in. I've seen both with and without in codes -- either works -- but the convention should be communicated to the user. For example, they need to know whether to supply tractions as force per unit length, or force per unit length and per radian. |
No description provided.