Skip to content

Tupek/solid axisym - #1638

Open
tupek2 wants to merge 7 commits into
developfrom
tupek/solid-axisym
Open

Tupek/solid axisym#1638
tupek2 wants to merge 7 commits into
developfrom
tupek/solid-axisym

Conversation

@tupek2

@tupek2 tupek2 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/smith/physics/solid_mechanics.hpp
Comment thread src/smith/physics/solid_mechanics.hpp
Comment thread src/smith/physics/solid_mechanics.hpp
TEST(SolidMechanics, AxisymmetricPressureInnerResultant)
{
axom::sidre::DataStore datastore;
StateManager::initialize(datastore, "axisymmetric_pressure_inner_resultant");

@white238 white238 Aug 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be helpful to have a helper macro that gives you the test name?

Something like:

#define GTEST_FULL_NAME()                                                  \
    ([]() -> std::string {                                                 \
        const auto* info =                                                 \
            ::testing::UnitTest::GetInstance()->current_test_info();       \
        return info                                                        \
            ? std::string(info->test_suite_name()) + "_" + info->name()    \
            : std::string{};                                               \
    }())

It would return SolidMechanics_AxisymmetricPressureInnerResultant in this case.

I could do this outside of this PR if you think its useful.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say no need. I happens that a convenient/lazy name here is sometimes the test name, or similar.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have been bit by this problem in the past

@btalamini btalamini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@btalamini

Copy link
Copy Markdown
Member

I see you've changed the convention by putting the 2*pi factor in. I've seen both with and without in codes -- either works -- but the convention should be communicated to the user. For example, they need to know whether to supply tractions as force per unit length, or force per unit length and per radian.

@tupek2
tupek2 requested review from kswartz92 and white238 August 6, 2026 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants