Make mfem::FiniteElementSpace a std::shared_ptr in FiniteElementVector - #1626
Open
ebchin wants to merge 3 commits into
Open
Make mfem::FiniteElementSpace a std::shared_ptr in FiniteElementVector#1626ebchin wants to merge 3 commits into
ebchin wants to merge 3 commits into
Conversation
ebchin
commented
Jun 24, 2026
ebchin
commented
Member
- Allows StateManager's FESpace to remain valid even if a user-held FE Space or Dual's space is overwritten or goes out of scope
- Reinstates move assignment for FE Dual and FE Space, since they no longer break StateManager
ebchin
marked this pull request as ready for review
June 24, 2026 06:35
white238
reviewed
Jul 30, 2026
| const std::string output_dir = name + "_data"; | ||
|
|
||
| if (axom::utilities::filesystem::pathExists(output_dir)) { | ||
| GTEST_SKIP() << "Output directory already exists from a prior run: " << output_dir; |
Member
There was a problem hiding this comment.
Seems like these should be a failure not a skip
white238
reviewed
Jul 30, 2026
| /** | ||
| * @brief Get a shared pointer to the internal FiniteElementCollection | ||
| */ | ||
| std::shared_ptr<mfem::FiniteElementCollection> shared_coll() const { return coll_; } |
Member
There was a problem hiding this comment.
coll seems too generic since this is user-facing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.