Repository navigation
Allow optimization on NVPTX modules when line line numbers are emitted - #556
Merged
Merged
Conversation
ZwFink
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #514 made kernel source code discoverable from the IR module by emitting modules with line number information. To achieve this, it made it so Proteus, instead of stripping all debug info, strips only non-line-number debug information. But this actually raises the debug info level above the minimum required to have line number information, and the PTX compiler will not optimize these modules. This hugely affects Mneme's replay performance on CUDA machines.
This branch strips debug info from proteus modules, in line with existing behavior, but preserves source code locations.
This shows replay time with Mneme vs the runtime of the recorded kernel:
stencil