Repository navigation
Conversation
swayamg20
requested review from
changt,
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
October 23, 2026 16:31
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FfiQueue.putheld_lockfor the whole delivery, sosubscribeandunsubscribe, which every FFI request calls from its event loop, waited until the FFI callback thread had run every filter andcall_soon_threadsafe.subscribeandunsubscribereplace the subscriber list instead of mutating it, soputiterates without_lock, as suggested in the issue_put_lockkeeps concurrent puts serialized, so every subscriber still sees events in the same orderCloses #888
Testing
uv run pytest tests/rtc/test_ffi_queue.py tests/rtc/test_room_ffi_filter.py -q -W erroruv run mypy livekit-protocol livekit-api livekit-rtcuv run ruff check .anduv run ruff format --check .Scope
unsubscribeno longer waits for an in-flightput, so that put can still deliver its item to the removed queue.